Skip to content

fix: Fix installation errors when PowerShell is disabled by Group Pol…#789

Merged
liangshuo-1 merged 1 commit intolarksuite:mainfrom
f1tz:main
May 9, 2026
Merged

fix: Fix installation errors when PowerShell is disabled by Group Pol…#789
liangshuo-1 merged 1 commit intolarksuite:mainfrom
f1tz:main

Conversation

@f1tz
Copy link
Copy Markdown
Contributor

@f1tz f1tz commented May 9, 2026

…icy.

Summary

Fix installation errors when PowerShell is disabled by Group Policy.

Changes

  • Add extraction using the tar command as a fallback.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced ZIP extraction reliability on Windows by implementing multiple fallback extraction methods, ensuring the installation process succeeds even if the primary method encounters issues.
    • Improved error messaging to provide more detailed information when extraction fails, helping diagnose installation problems more effectively.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 9, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c9d6971c-ce9a-47e2-b31e-96ed29f5c715

📥 Commits

Reviewing files that changed from the base of the PR and between 6e22a7e and 02974ed.

📒 Files selected for processing (1)
  • scripts/install.js

📝 Walkthrough

Walkthrough

The PR enhances Windows ZIP extraction resilience by adding a tar -xf fallback when PowerShell Expand-Archive fails, following an initial .NET ZipFile attempt. Error reporting consolidates messages from all three extraction methods.

Changes

Windows ZIP Extraction Resilience

Layer / File(s) Summary
Extraction Fallback and Error Handling
scripts/install.js
When Expand-Archive fails, code attempts tar -xf extraction before throwing. Final error message aggregates all three extraction failures.

Possibly related PRs

  • larksuite/cli#713: Both PRs modify scripts/install.js's extractZipWindows helper to make Windows ZIP extraction more resilient: the retrieved PR added a .NET primary extraction with an Expand-Archive fallback, and the main PR further adds a tar -xf fallback and expands the error message

Suggested labels

size/M

Suggested reviewers

  • liangshuo-1

Poem

🐰 A rabbit hops through Windows with glee,
ZIP files falling from every tree,
Tar comes to help when PowerShell sighs,
Three extraction paths now reach the skies! ✨
Errors compile like carrots to munch,
Resilience served with a crunchy bunch!


🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the summary and changes sections, but is missing the required Test Plan and Related Issues sections from the template. Add Test Plan section with checkboxes for unit tests and manual verification, and explicitly state the Related Issues section (even if empty).
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a fallback extraction method when PowerShell is disabled by Group Policy on Windows.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.46%. Comparing base (6e22a7e) to head (02974ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files         510      510           
  Lines       47129    47129           
=======================================
  Hits        30851    30851           
  Misses      13607    13607           
  Partials     2671     2671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@02974ed464c06065b183785e1bd63f3eabeb1376

🧩 Skill update

npx skills add f1tz/cli#main -y -g

@liangshuo-1 liangshuo-1 merged commit 44ffa98 into larksuite:main May 9, 2026
19 checks passed
@liangshuo-1 liangshuo-1 mentioned this pull request May 9, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants