Skip to content

docs(lark-vc): clarify meeting search evidence flow#866

Merged
BytedanceSearch merged 2 commits into
mainfrom
eval-search-vc-routing-docs-a970
May 19, 2026
Merged

docs(lark-vc): clarify meeting search evidence flow#866
BytedanceSearch merged 2 commits into
mainfrom
eval-search-vc-routing-docs-a970

Conversation

@BytedanceSearch
Copy link
Copy Markdown
Collaborator

@BytedanceSearch BytedanceSearch commented May 13, 2026

Summary

  • Clarify that VC list-style requests should filter by time/person first, not generic query words.
  • Replace fixed relative-date examples with runtime placeholders.
  • Add guidance to fetch notes/recordings/minutes before summarizing agendas, decisions, or participation.
  • Keep this PR scoped to skills/lark-vc/** only.

Eval Signal

Runs:

  • tests/eval-search/runs/2026-05-12T06-14Z-multientity-sandbox-a970
  • tests/eval-search/runs/2026-05-13Tfull-critical-info-sandbox

Observed:

  • VC list-style cases need time/person filtering first, then notes/recording fetch for agenda or participation summaries.
  • "All/stat/sort" requests should paginate and de-duplicate before summarizing.

Validation

  • git diff --check
  • PR diff is scoped to skills/lark-vc/**.

Docs-only change; no unit tests were run.

Summary by CodeRabbit

  • Documentation
    • Clarified search query best practices to focus on meeting-keyword content only (avoid action-like phrases).
    • Recommended two-stage search: broad time/people filters then follow-up retrieval via notes/recordings/minutes.
    • Added concrete command examples for participant/organizer time-range searches and guidance to compute YYYY-MM-DD from execution date for relative ranges.
    • Stipulated summaries must not fabricate issues when notes/recordings are missing.
    • Enhanced pagination to complete deduplication before sorting or statistics.

Review Change Stack

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 13, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f6fe23b-4a57-43a9-a8e6-117bd64a1129

📥 Commits

Reviewing files that changed from the base of the PR and between 6b129ca and 57879c8.

📒 Files selected for processing (1)
  • skills/lark-vc/references/lark-vc-search.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-vc/references/lark-vc-search.md

📝 Walkthrough

Walkthrough

This PR refines vc +search documentation: narrows --query to meeting keywords, prescribes a two-stage search (broad time/people filters then follow-up via notes/recording/minutes), adds relative-time examples using --start/--end with participant/organizer filters, requires computing YYYY-MM-DD from execution date, and changes pagination/aggregation ordering.

Changes

vc +search command guidance

Layer / File(s) Summary
Query restriction and search examples
skills/lark-vc/references/lark-vc-search.md
--query must contain only meeting-keyword content (not action-like phrases). Recommends two-stage workflow: broad search by time/people, then retrieve details via vc +notes / vc +recording / minutes using meeting_id. Adds examples for "this month I participated" and "last two weeks I organized" using --start/--end date placeholders and --participant-ids / --organizer-ids (omitting --query). Mandates computing "<YYYY-MM-DD>" from the execution date for relative-time placeholders.
Pagination and aggregation behavior
skills/lark-vc/references/lark-vc-search.md
When users request "all", "everything", "statistics", or time-sorted results, complete pagination and deduplication across all pages first, then perform sorting or compute statistics; do not rely on only the first page even if total > 50.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • larksuite/cli#591: Updates vc +search follow-up routing guidance for using vc +recording to retrieve minute_token and subsequent minutes API calls.

Suggested reviewers

  • zhicong666-bytedance
  • zhaoleibd

Poem

🐰 In search I hop with clear intent,
Dates freshly baked and queries meant,
First scan by time and people wide,
Then fetch the notes where truths abide,
Hooray for tidy vc +search stride.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs(lark-vc): clarify meeting search evidence flow' accurately reflects the main change—updating documentation to clarify the evidence flow for meeting search, filtering strategy, and pagination behavior.
Description check ✅ Passed The description includes a clear summary of changes and validation approach, but lacks explicit Test Plan and Related Issues sections from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eval-search-vc-routing-docs-a970

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact labels May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.39%. Comparing base (e511404) to head (57879c8).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   67.02%   67.39%   +0.37%     
==========================================
  Files         569      572       +3     
  Lines       53508    53659     +151     
==========================================
+ Hits        35864    36165     +301     
+ Misses      14649    14486     -163     
- Partials     2995     3008      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: I997ec0654b9448eb0cc6ed7c15493dd2316ffa39
@BytedanceSearch BytedanceSearch force-pushed the eval-search-vc-routing-docs-a970 branch from bdd318c to 6b129ca Compare May 19, 2026 06:32
@BytedanceSearch BytedanceSearch marked this pull request as ready for review May 19, 2026 09:14
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-vc/references/lark-vc-search.md`:
- Around line 147-148: Clarify precedence between the pagination-threshold rule
and explicit "all" requests by updating the two bullets: state explicitly
whether an explicit user request containing "所有 / 全部 / 统计 / 按时间排序" overrides the
confirmation requirement when `total > 50` (or conversely that confirmation is
still required); e.g., change the `total`-threshold bullet and the "用户说..."
bullet to a single sentence that defines the precedence (either "explicit 'all'
requests bypass confirmation and auto-fetch all pages" or "explicit 'all'
requests still prompt for confirmation when `total > 50`") and include the
condition `total > 50` and the trigger phrases "所有 / 全部 / 统计 / 按时间排序" so readers
can find and enforce the rule in code (search for `total > 50` and those trigger
phrases).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b882a5e-ecbc-4ead-bba3-c1654eb90bbf

📥 Commits

Reviewing files that changed from the base of the PR and between e511404 and 6b129ca.

📒 Files selected for processing (1)
  • skills/lark-vc/references/lark-vc-search.md

Comment thread skills/lark-vc/references/lark-vc-search.md Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@57879c86aaa7b7cedf6f57451d80ec465d10e87a

🧩 Skill update

npx skills add larksuite/cli#eval-search-vc-routing-docs-a970 -y -g

Change-Id: Icdcc38db2ce3db3a3371c6451624fd52a71170e3
@BytedanceSearch BytedanceSearch merged commit 939b7b6 into main May 19, 2026
22 checks passed
@BytedanceSearch BytedanceSearch deleted the eval-search-vc-routing-docs-a970 branch May 19, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants