docs(mail): expose user_mailbox.allow_senders/blocked_senders#943
docs(mail): expose user_mailbox.allow_senders/blocked_senders#943haidaodashushu wants to merge 2 commits into
Conversation
Surface the new per-user allow / blocked sender resources (list / batch_create / batch_remove) in skills/lark-mail/SKILL.md so AI agents can discover and call them via the native API path. Both resources reuse the existing mail:user_mailbox.message scope namespace; no new scope is introduced. Also add an "信任/屏蔽发件人 (Allow/Block List)" entry to the mail domain skill template so the new concept appears under "核心概念" alongside Rule and Template. SKILL.md is regenerated by the registry pipeline from this template plus the refreshed mail meta; the incidental description / wording updates on existing resources are the same regeneration's output. skills/lark-mail/SKILL.md is the only generated artifact tracked in this repo; internal/registry/meta_data.json stays gitignored and is fetched at build time. sprint: S8
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds documentation for a new mail sender filtering feature: an Allow/Block List concept, two new mailbox API resources ( ChangesAllow/Block List Mail Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Around line 567-568: The resource index is missing descriptions for
user_mailbox.rules.reorder and user_mailbox.rules.update; update SKILL.md to add
concise descriptions for both methods that state their purpose, required
parameters, return values, and error behavior—for example, explain that
user_mailbox.rules.reorder reorders rule IDs in the mailbox and accepts an
ordered list of rule IDs (returns the updated ordering or success status), and
that user_mailbox.rules.update updates a single rule by ID with provided rule
fields (returns the updated rule or an error if validation fails); ensure the
descriptions mention notable constraints (e.g., atomicity, validation) and match
the style/format of the surrounding API entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 73f74fd4-fdb4-4efe-82cb-69e554485f09
📒 Files selected for processing (2)
skill-template/domains/mail.mdskills/lark-mail/SKILL.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 65.92% 67.62% +1.69%
==========================================
Files 523 575 +52
Lines 49694 54336 +4642
==========================================
+ Hits 32760 36743 +3983
- Misses 14134 14549 +415
- Partials 2800 3044 +244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@20a2c478d3136ad7c3e2545c1752756f4b193f6f🧩 Skill updatenpx skills add haidaodashushu/lark-cli#feat/27a6227 -y -g |
Per CodeRabbit review on PR larksuite#943 (skills/lark-mail/SKILL.md L567-568): the user_mailbox.rules.reorder / user_mailbox.rules.update entries in the resource index had empty descriptions. Filled with one-line descriptions following the style of the surrounding entries (e.g. user_mailbox.templates.update). Both descriptions state semantics + full-replacement / ordering invariant so users scanning the index can tell them apart from create/delete. Change-Type: ci-fix
Expose mail user mailbox allow/block sender resources through the CLI metadata so users can invoke
list / batch_create / batch_removeagainst the new endpoints from the lark-cli surface.Changes
mail.user_mailbox.allow_sendersandmail.user_mailbox.blocked_sendersresources (list / batch_create / batch_remove).mail:user_mailbox.message:readonly/mail:user_mailbox.message:modifyscopes — no new scope namespace.Sprints
This PR was created autonomously. Quality gates were enforced by the repo's pre-commit hooks.
Summary by CodeRabbit