fix: sheets scope typo, IM flag docs, dry-run membership warning, proxy warning env var#976
fix: sheets scope typo, IM flag docs, dry-run membership warning, proxy warning env var#976mengqiuzhen wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughReplaces all occurrences of ChangesSheets OAuth Scope Correction
Miscellaneous
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ishu Open Platform The scope "sheets:spreadsheet:read" is not recognized by the Feishu Open Platform. The correct read scope for sheets is "sheets:spreadsheet:readonly", as defined by the Feishu OpenAPI schema and already referenced in scope_overrides.json. Using the wrong scope name causes token authorization gaps — the granted token lacks the expected permission for sheets shortcuts. Closes larksuite#838 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…y-run membership warning larksuite#872: --image/--file/--video/--audio flag descriptions now say "relative path to file" instead of "local file path", so users and AI agents know absolute paths are rejected before hitting the validation error. larksuite#915: im +messages-send --dry-run now appends a membership caveat when --chat-id is used, clarifying that dry-run only validates request shape, not chat membership. larksuite#811: add LARK_CLI_NO_PROXY_WARNING env var to suppress the per-invocation proxy warning while still using the proxy, for scripted/agent callers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The sheets scope change in this PR (
I'd suggest reverting the sheets scope changes (the Ref: #909 |
…ching Feishu Open Platform" This reverts commit 1122127.
|
Thanks for the PR! |
Summary
Four small fixes across 3 areas:
#838 — sheets scope name typo
Fixed
"sheets:spreadsheet:read"→"sheets:spreadsheet:readonly"across all sheets shortcuts, scope_priorities.json, and tests. The wrong scope name is not recognized by Feishu Open Platform. Confirmed vialark-cli schema sheets.spreadsheets. (40 replacements, 11 files, string-only.)#872 — media flag --help now documents relative-path restriction
--image/--file/--video/--audioflag descriptions changed from "local file path" to "relative path to file" inim +messages-sendandim +messages-reply, so users learn the restriction from --help instead of hitting a validation error at runtime.#915 — dry-run warns it does not verify chat membership
im +messages-send --dry-runnow appends a caveat when--chat-idis used. Prevents agents from misinterpreting dry-run success as proof the bot/user can deliver to the chat.#811 — new
LARK_CLI_NO_PROXY_WARNINGenv varScripted/agent callers can now silence the per-invocation proxy warning with
LARK_CLI_NO_PROXY_WARNING=1while still using the proxy. (LARK_CLI_NO_PROXY=1already disables the proxy entirely; this only suppresses the stderr warning.)Verification
go build ./...— cleango test ./internal/registry/...— all passgo test ./internal/util/...— all passgo test ./shortcuts/im/...— all pass (including DryRun shape tests)go test ./shortcuts/sheets/...— pass (2 pre-existing image test failures unrelated)Closes #838
Closes #872
Closes #915
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation & Improvements