Use test sharding to parallelise the tests. #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamHillier
commented
Oct 21, 2020
| native.sh_test( | ||
| name = sh_name, | ||
| size = "medium", | ||
| size = "large", |
There was a problem hiding this comment.
I've made this "large" because otherwise the 'big' kernel tests which don't run on CI timeout.
AdamHillier
force-pushed
the
test-sharding
branch
from
d0c7826 to
281ed1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Our CI runs on machines with two cores. Bazel supports test sharding which when enabled parallelises the tests over multiple processes. All we need to do is add a
shard_countattribute to the test definition.Note that the 'small' kernel tests which run on CI don't test multithreaded convolutions, so there's no problem testing two in parallel.