Add bounds checks tests for MT940 structured parsing#25
Merged
larsdecker merged 5 commits intomasterfrom Dec 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds security bounds checks to three MT940 parsing functions to prevent processing of excessively long input strings that could impact performance or security. The changes include input length validation with appropriate error handling and comprehensive test coverage for these new bounds checks.
- Added length validation checks (1000 chars for
parsePaymentReferenceDateandparsePaymentReferenceTan, 10000 chars forassemblePaymentReference) - Implemented error throwing when input exceeds defined limits
- Added comprehensive test suites covering boundary conditions, error cases, and valid input scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 15 comments.
| File | Description |
|---|---|
| packages/fints/src/mt940-86-structured.ts | Added bounds check validation to three parsing functions with error handling |
| packages/fints/src/tests/test-mt940-86-structured.ts | Added three new test suites with 9 tests total covering bounds validation, edge cases, and normal operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.