Skip to content

Consolidate Prettier configuration into single .prettierrc.json file#26

Merged
larsdecker merged 2 commits intomasterfrom
copilot/consolidate-prettier-configuration
Dec 27, 2025
Merged

Consolidate Prettier configuration into single .prettierrc.json file#26
larsdecker merged 2 commits intomasterfrom
copilot/consolidate-prettier-configuration

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 27, 2025

Two conflicting Prettier configs existed (.prettierrc and .prettierrc.json), causing ambiguity in formatting rules.

Changes

  • Merged configurations into .prettierrc.json

    • Changed trailingComma: "es5""all" for cleaner TypeScript diffs
    • Added jsxSingleQuote: false from .prettierrc
    • Retained: printWidth: 120, tabWidth: 4, singleQuote: false, and other shared settings
  • Removed .prettierrc to maintain single source of truth

No code formatting changes required - existing files already comply with consolidated config.

Original prompt

Konsolidiere die Prettier-Konfiguration: Zusammenführen der vorhandenen .prettierrc und .prettierrc.json, beibehalten als einzige Konfigurationsdatei (.prettierrc.json) und Entfernen der doppelten .prettierrc-Datei.

Hintergrund:

Änderungen, die der PR vornehmen soll:

  1. Aktualisiere/ersetze die Datei .prettierrc.json mit einer konsolidierten Konfiguration, die Einstellungen aus beiden Dateien zusammenführt und widersprüchliche Werte auflöst.
    • Beibehaltung technischer Vorgaben aus beiden Dateien (z. B. printWidth: 120, tabWidth: 4).
    • Wähle trailingComma: "all" (aus .prettierrc) statt es5 um konsistentere diffs bei TS/JSON/objects zu haben.
    • Setze jsxSingleQuote: false (aus .prettierrc) zusätzlich zur bestehenden singleQuote: false.

Proposed consolidated .prettierrc.json (dieser Inhalt soll die neue Datei werden):

{
  "printWidth": 120,
  "tabWidth": 4,
  "useTabs": false,
  "semi": true,
  "singleQuote": false,
  "jsxSingleQuote": false,
  "quoteProps": "consistent",
  "trailingComma": "all",
  "bracketSpacing": true,
  "arrowParens": "always",
  "endOfLine": "lf"
}
  1. Entferne die Datei .prettierrc (die einfache .prettierrc JSON-Datei), damit nur noch die eine konsolidierte Konfiguration existiert. Die zu entfernende Datei ist hier: https://github.com/larsdecker/fints/blob/0e54739ce7d13b79223bfb659b3d41297940ac68/.prettierrc

  2. Kurze PR-Beschreibung / Commit-Message: "chore: consolidate Prettier config into .prettierrc.json and remove duplicate .prettierrc"

Warum diese Entscheidungen?

  • Eine einzelne Konfigurationsdatei vermeidet Verwirrung und stellt sicher, dass Prettier deterministisch die erwarteten Regeln anwendet.
  • .prettierrc.json ist bereits vorhanden im Repo; JSON-Dateien sind klar, werden von Prettier unterstützt und leicht von CI/Tools gelesen.
  • trailingComma: "all" passt gut zu TypeScript-Projekten und reduziert diff-Lärm bei hinzugefügten Feldern.

Bitte erstelle den PR auf repository: larsdecker/fints mit diesen Änderungen.

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…uplicate .prettierrc

Co-authored-by: larsdecker <1968186+larsdecker@users.noreply.github.com>
Copilot AI changed the title [WIP] Consolidate Prettier configuration into .prettierrc.json Consolidate Prettier configuration into single .prettierrc.json file Dec 27, 2025
Copilot AI requested a review from larsdecker December 27, 2025 02:22
@larsdecker larsdecker marked this pull request as ready for review December 27, 2025 02:22
Copilot AI review requested due to automatic review settings December 27, 2025 02:22
@larsdecker larsdecker merged commit a7a0f2c into master Dec 27, 2025
9 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates two conflicting Prettier configuration files into a single source of truth, eliminating ambiguity in code formatting rules.

  • Merged .prettierrc and .prettierrc.json into a single .prettierrc.json file
  • Changed trailingComma from "es5" to "all" for cleaner TypeScript diffs
  • Added jsxSingleQuote: false from the old .prettierrc file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.prettierrc.json Updated with consolidated configuration merging settings from both files, including trailingComma: "all" and added jsxSingleQuote: false
.prettierrc Removed duplicate configuration file to maintain single source of truth

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants