Add lch_buffer_t type to the C FFI#174
Merged
Merged
Conversation
Introduce an lch_buffer_t struct holding the (uint8_t *data, size_t len) pair, and use it across the C API for patch buffers. The previous double pointer + size pair is replaced with a single caller-owned struct that the library fills in. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The buffer type is now generic (lch_buffer_t), so the free routine should be too. Update the C header, Rust FFI, C smoke test, man page, and README example. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lch_buffer_t { uint8_t *data; size_t len; }ininclude/leech2.hand use it across the FFI for patch buffers inlch_patch_create,lch_patch_to_sql,lch_patch_inject, andlch_patch_applied. Output buffers are now filled into a caller-owned struct instead of returned via paireduint8_t**/size_t*out-params.lch_patch_freetolch_buffer_freeto match the now-generic buffer type. The function also resetsdata/lenafter freeing so a double-free is a no-op.lch_patch_injectwas also brought in line with the typed-cell API (it still referenced the oldvalue/kindstring parameters).