Conversation
Owner
Author
There was a problem hiding this comment.
I added protection here. I'm surprised we didn't have this before. Basically if you call ec.play(), you need to call ec.stop() before calling ec.play() again. This will undoubtedly save users some pain of not understanding that the TDT must be stopped and reset (which happen in the stop method) before play actually means "play from the beginning".
Owner
Author
There was a problem hiding this comment.
@drammock this is an important check to save users some pain. Eventually we can add the other sanity checks we talked about today, too.
Owner
Author
|
CRAP opened this to the wrong master. My bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LABSN#79.
@drammock this is be ready for review and discussion of how to change/adapt/extend the API, only WIP because it's missing an example. You can review it now if you want, but I think the example will make it easier for you to see the functionality.