Generic packet #140
Merged
Generic packet #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
force-pushed
the
generic-packet
branch
from
8e3093c to
6000d0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 91.89% 92.11% +0.22%
==========================================
Files 36 37 +1
Lines 2553 2614 +61
==========================================
+ Hits 2346 2408 +62
+ Misses 207 206 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
greglucas
force-pushed
the
generic-packet
branch
from
7565829 to
917df01
Compare
medley56
reviewed
Mar 11, 2025
Member
medley56
left a comment
medley56
left a comment
There was a problem hiding this comment.
I still am not convinced the packet_generator method on the definition object is truly generic because it's calling ccsds_generator internally to create the CCSDSPacketBytes objects for parsing. The parsing appears to be fully generic but the generation of the packet bytes seems to still rely on CCSDS.
5 tasks
This moves towards a generic packet interface and removes the need for passing in bytes with a read_* interface, we now wrap that in our own reader class to simplify that interaction.
We can add these properties back onto the main "Packet" class and add a user warning when being accessed to make it easier to transition to the new style and provide a helpful message.
Deprecate parse_ccsds_packet() as the XTCE spec doesn't need to know about the ccsds standard. We should handle parsing raw bytes objects and create the underlying objects for the users ourselves.
It is specific to ccsds packets and hasn't been released yet, so just keep it over there instead.
greglucas
force-pushed
the
generic-packet
branch
from
11dc83b to
714299d
Compare
greglucas
force-pushed
the
generic-packet
branch
from
714299d to
f94ece7
Compare
medley56
approved these changes
Aug 1, 2025
greglucas
force-pushed
the
generic-packet
branch
from
0905a0a to
8487768
Compare
medley56
reviewed
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to refactor our xtce parsing to be more generic and allow any RawDataObject, not just ccsds packets.
Thoughts/suggestions on how to make this better for other packet types are welcome!
definition.parse_packet(bytes)and not our wrapped classes that add the reading methods. Perhaps we could wrap the input bytes into our own container class within the function itself which would remove some of the user-facing need to create a RawPacketData-like object with read_* methods on it.closes #130
Checklist