MNT: Add backcompat shim to ease transition to new packet file loading #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
commented
Feb 18, 2025
greglucas
force-pushed
the
xtce-back-compat
branch
from
65cde5d to
7f95ac2
Compare
greglucas
force-pushed
the
xtce-back-compat
branch
from
b2ca857 to
c96394e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 91.82% 91.86% +0.04%
==========================================
Files 35 36 +1
Lines 2543 2557 +14
==========================================
+ Hits 2335 2349 +14
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
medley56
approved these changes
Feb 26, 2025
Member
medley56
left a comment
medley56
left a comment
There was a problem hiding this comment.
Nice. This is good user support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to profile things across versions, it got a little annoying to comment/uncomment lines of files for the different loading XTCE patterns. This adds a small shim layer for the old
XtcePacketDefinitionformat that then warns and suggests how to transition to the new patterns, still working the same as previously.