MNT: Make packet class be a mapping based on data items #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medley56
reviewed
Sep 17, 2024
medley56
reviewed
Sep 17, 2024
medley56
approved these changes
Sep 17, 2024
Member
medley56
left a comment
medley56
left a comment
There was a problem hiding this comment.
Looks good. Couple of comments but I like combining the raw data with the parsed items.
greglucas
force-pushed
the
packet-repr
branch
2 times, most recently
from
f2f9f83 to
952c5f0
Compare
medley56
reviewed
Sep 25, 2024
Member
medley56
left a comment
medley56
left a comment
There was a problem hiding this comment.
Minor docstring change suggestions.
medley56
force-pushed
the
packet-repr
branch
3 times, most recently
from
f089946 to
9cdfa36
Compare
This allows a user to index directly into the packet itself. Rather than being defined by the raw bytes. Separate out the raw packet data and the packet object
medley56
force-pushed
the
packet-repr
branch
from
9cdfa36 to
b232196
Compare
medley56
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to index directly into the packet itself. Rather than being defined by the raw bytes.
Separate out the raw packet data from the packet object itself to keep these as two separate things.
Checklist