Fix byte reading/writing to use the correct size in SaveImage()#18
Merged
Conversation
Owner
|
Yes it has been fixed in the later version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered this bug while exporting .img files from a .wz file, where the exported .img was either corrupted (with fewer bytes than expected) or excessively large (with more bytes than expected).
This issue occurs because the code reads and writes data based on the current position, rather than the actual image size.
While creating this PR, I realized I had been using my own build based on v7 for a long time. I tested v8 and v9, and both work fine. I then found that this bug had been fixed, but I think the fix was not entirely correct, so I just reverted it.
P.S. This bug has existed since the fork’s inception. Original code from hadeutscher