NavBar buttons (other than AJAX search icon) need their own coloring #247
Labels
Milestone
Comments
|
That looks a bit odd, at least with the default Bootstrap coloring, since there's no real 'definition' that that's a button: |
|
It's more of a wording issue. The ZCA Bootstrap Colors admin page refers to "Header Nav Bar Button", yet the values don't apply to any button in the nav bar except the hamburger menu button. |
|
So, perhaps just changing the wording associated with that color-setting to make it more obvious? |
|
That would be less confusing/misleading, though I personally prefer to be able to set the navbar buttons values different that the other buttons. Not a show-stopper issue. |
|
Point taken. I'll take a quick peek at those button defaults .... seems like at least a non-background border-color would suffice to enable the coloring to apply to all buttons in the header. |
|
also missing are all the combinations for .alert-info. It is rarely seen but, if we are going to allow the ease of color change.... .alert-info {color: #13525e, background-color: #d1ecf1, border-color: #bee5eb based on defaults. Should I add that when fixing the spaces? |
|
Let's keep the changes separate. If you do the 'heavy lifting' on the current coloring-changes, I'll get this one. |
Noting that those were/are included in the updates for #253. |
lat9
added a commit
that referenced
this issue
Jul 4, 2023
lat9
added a commit
that referenced
this issue
Jul 5, 2023
lat9
added a commit
that referenced
this issue
Jul 5, 2023
#247: NavBar toggler and extra buttons color-constant updates/additions
lat9
changed the title
lat9
added a commit
that referenced
this issue
Oct 14, 2024
* #231: Update versioning and readme * #232: Removing unneeded PHP Warning log * #233: Model data center-aligned on listings * #234: Defining 'PAGE_ACCOUNT_HISTORY' * #235: Add quantity text on products' listings * Update readme/init for v3.5.3 release * Update README.md for v3.5.3 * #240: Simplify featured/all/new page header processing * #240: Update readme/init/template-info * #241: Correct 'greedy' handling for pricing notifications * #245: Correct "Add Address" button on `address_book` page * #244: Add 'soft' control for `c2z` zone key value * #238: Add 'soft' setting to disable back-to-top display * #252: Accessibility update for table-based product listings * #252: Addendum to readme for upgrades ... ... that introduce new language constants and/or color-configuration settings. * #246: Adding 'role="button"' to AJAX search ... ... for SEO improvement. * #254: Add spacing for price and min-max-unit elements ... ... on table-based product listings. * #237: Use default Zen Cart handling for AJAX timeouts * #236: AJAX Search, add notifications and restructure * Moving 'pages' documentation to wiki articles * Update init_bc_config_install_or_upgrade.php Up to date with nomenclature, previously omitted options, and colors. * Update stylesheet_zca_colors.php Up to date with nomenclature, previously omitted options, and color designsations. * Missing quote causes PHP Parse error in admin * 'set_default' not appropriate for newly-added colors ... ... that weren't previously defined. The default color might not be compatible with a site's pre-existing color scheme. * Correcting debug-logs on undefined color-constants ... ... if a pre-existing site's storefront is 'hit' before the admin's had a chance to install the colors. Also recognizes that the newly-added colors might not yet have been set. * Updating readme and admin configuration * #247: Start with renaming the toggler colors * #247: Add colors for extra navbar buttons * #261: Sold Out coloring and cursor * #259: Correct modal addl. images html validation * #258: zc158a+ call-for-price and ask-a-question * Update tpl_account_history_info_default.php Bring in line with 1.5.8b use overrides for language elements * #258: Readme plus language file version comments * Rename accout_history_info.php to account_history_info.php #258 and #264, Correcting zc157 language file name * #266: Floating "Add Selected to Cart" Note that there's an additional `.css` file (stylesheet_360.css). Without that, a site's browser-cached version of the base stylesheet.css would require customers to "Force Reload" to bring the styling in. * Update readme's and versions for v3.6.0 release * #271: Correct accessibility issue on index pages (empty <h1>) Note that for zc200 the newly-added constant is anticipated to be in /includes/languages/english/lang.index.php. * Accesability on previous and next buttons update version chage requested by @lat9 restore version numbers * #278: Update readme for changes, init for 3.6.1-beta1 * #276: Correct misspelling of `cursor` in CSS file * #278: Correcting constant used for tpl_bootstrap_images.php * #279: On-page shipping estimator, fit to content * #280: Add intervening spaces on shopping-cart display * #284: shopping_cart page, refactoring for small screens * #279, #284: Add "cache-busting" stylesheet ... reverting change out of the `stylesheet.css`. * #281: Correcting "Update Quantity" icon * #281: Note change in readme * #286: Correcting delete icon/checkbox overlap when fixed-quantity ... ... product is in the cart. * #281: Fixed quantity, add hidden field to unused "Update" column * #288: Update jQuery to v3.7.1 * #289: Correcting header/logo layout * Update readmes/init for v3.6.1 release * correct path and typos * Rearrange logic parentheses Corrects #299 * #299: Update readme, copyright, last updated * #298: Remove extraneous tags from the changes suggested * #297: Variable name change in v200 (review write page) Note: Includes some minor reformatting/refactoring. * #290: New notifiers on `account_history_info` page * #290: Correcting variable on notification ... ... it's different than the zc200 `template_default` (sigh). * #274: Updating default rating stars' color/background-color * #296: ZCA Bootstrap Colors, UI improvements ... ... and exporting the default color-code to the .csv. * Update readme and versions for v3.6.2 release * #302: Correct out-of-date version reported * #302: Update readme, versions * #304: Correcting multiple trashcans on small screens * #303: Support zc200's wholesale pricing displays * #304: Minor reformatting/refactoring - "Lose" extraneous whitespace - Use exactly-equal-to where appropriate - No single-line conditional - Use foreach instead of while/MoveNext for empty-cart blocks. * #306: Updates for zc200's SNAF incorporation * #307: Correct tpl_modules_listing_display_order PHP Warnings Includes (as always!) reformatting and refactoring as well as the actual changes (lines 13-17) * #310: Correct display on Chrome when using device-toolbar * #311: Use page-specific max values for SNAF listings * #312: Correct PHP warning on index listing * #313: Include alpha-filter on products_all, if enabled * #314: Correct missing settings when upgrading from way-old version * #305: Enabling a fluid display on category listings * #307: Align layout with zc200 solution * Update readmes/init for v3.6.3 release * #315: Correct "dead" link in site-specific-styles.css * Add disp_order sort fix * #317: Updating readme/comments to reflect change * Start by refactoring * Remove redundant section (the actual fix) * #323: Correct new-products' centerbox image dimensions * #320: Correcting modal shipping-estimator display ... also removes readme guidance for upgrading from woefully old v2.0.0c of the template. * #324: Style links with underline * Changes required for accessibility page * #327: Update module version and readme * #328: Update centerbox titles for accessibility * #329: Remove `Delete` button for "Primary" addresses * #326: Add wrapper for also-purchased centerbox * Start with reformatting/refactoring * Update tpl_columnar_display.php to be more re-usable ... allows code shrinkage in the majority of the centerboxes as well as category-row rendering. * Missed version-comment update * #333: Correct zc157 logs on `products_all` page. * #333: Correct now-missing closing parenthese * #332: Add config setting for "Add Selected to Cart" positioning * #335: Correct alpha-sorter accessibility issue ... also contains some refactoring. * #336: Identify support for zc200/PHP 8.3 * #338: Account for credit selections that don't have selections * #339: Retain OPC shipping module heading if no methods available * #340: Define 'TOPMOST_CATEGORY_PARENT_ID', if not already * Update readmes/init for v3.6.4 release * #342: Preserve filters for listing display-order selection * #344: Correct zc158 missing constant * #343: Add display-order select to products'/specials' listings * #343: Include the code updates, too * Start with some reformatting/refactoring - No 1-line conditionals - Indent PHP/HTML to line-up start/end elements - Use foreach for the attributes' display - Remove redundant HTML comments * Use short-echo tags * ... and the actual correction * #345: Remove use of no-longer-present variable * add titles to links * #349: Use `zen_get_products_name` for listings * #349: Update readme. * fix missing end bracket * Accessabiliy issue order of headings Need to change itemTitle from <h5> to <p> to score 100 on accessability in google chrome * correct documentation * #353: Enable `zca_splitPageResults` to be overridden * #355, #356: Updating tpl_header.php * #345: Add change to readme * Update readmes/init for v3.6.5 release * add var to remove categories with no products * dist. comment out line * #360: Additional refactoring * Correct readme.html extra_definitions directory * Apply zero-product categories' change to sidebox and category-row modules (#361) * Updating versions, categories-sidebox for 0-product categories * #360: Categories' sidebox and category-row updates - Refactoring for categories' sidebox - Add support in category-row so that zero-product categories aren't displayed * #360: Updating readme.html/admin-init * #360: Swap soft-setting's default for downward compatibility * #359: Correct layout for 'columns' display - Also includes some reformatting/refactoring for the product_listing.php module. * #365: Incorporate zc158-era changes for attributes module * #363: Correct MySQL ANSI-mode issues * #358: Update html_header.php (#265) * Update html_header.php Have updated html header to font Awesome 6 Corrected error that stopped preload working change loads to loop rather than hard coded list Have left in the fa4-shim as bootstrap was on fa-5 it is probably not required. will take out if you don't want it. * Added no preload to boostrap site specific settings * Bring up to date with 3.7.0 and requested changes * Font awsome 6.5.2 + rebase to 3.7.0 * #362: Drop support for zc157 (#366) * #362: Drop support for zc157 * #362: Drop support for zc157 * #362, #358: Update readmes/template_info.php - With minor reformatting to common/html_header.php * #358: Correct integrity value, remove v4-shim - Previous versions of the template were based on FA-5, not FA-4, so no need for a FA-4 shim. * #160: Sync product info templates (#364) * #160: Start by reformatting/refactoring the `product_info` template * The actual modifications * #160: Update readme to show changes * #367: Corrections for ZCA Colors uninstall SQL * #291: Include the "Home Page Slider" component ... previously a template addition. * tpl_search_header.php: `;` should be `.` Fixes #368 * #308: Correct placement of `<main>` tag * #369: Enable different container types header/main/footer ... also includes previously-missed configuration additions for the home-page slider #291 * #292: Alternate `checkout_shipping` messaging when no methods available * #285: Control pricing location(s) when product has attributes * #370: Move `charset=` meta-tag; HTML validation * #371: Correct rating stars' output * #372: Enable carousel display on various sideboxes (#373) * #372: Correct variable misspelling in reviews sidebox * #377: Adding matching-height jQuery scripts * #277: Need to match heights on sideboxes' `.card` classes ... for fully non-jiggly output. * #375: Centerbox carousels (#376) * #375: Centerbox carousels * Update readme.html to reflect changes. * #372: (Sigh) missed the final update * #377: Add version commentary to new module * #378: Enable sidebox carousels to 'fade' * correct vars (#379) * #380: Correct `checkout_confirm` coloring - Update version last updated - Refactor to use short-echo tags. * jscript_matching_heights missing actual script name Fixes #381. * #360: Account for 'Show Category Count' setting Fixes #383 Closing the above issue with this commit, since the issue was introduced in the subject-referenced issue's update. * #384: Add zc200 notifications to sideboxes * #385: Move 'header' messages so they display ... ... they were being hidden by the fixed-top navbar. * Update readme/init versions for v3.7.0 release * Update tpl_checkout_payment_default.php (#387) Correct warning message : --> PHP Warning: Undefined variable $comments_heading in /home/lotus/public_html/innerlightcrystals/sales/includes/templates/bootstrap/templates/tpl_checkout_payment_default.php on line 251. * #388: Adding version/readme update * #389: Removing date-related comments from template_info.php * #390: Support forthcoming zc210's additional-images' handling * #392: Correct `gv_faq` page's form-entry default. ... also changing to use short-echo tags. * #394: Simplify variable name for shipping estimator * #397: Add styling to display non-bootstrap-formatted checkboxes * #390: Additional images' slider needs the change, too! * #393: Correct title of base image's additional-images' carousel-indicator * #399: Apply ZC base simplification to tpl_account_default.php * #399: Use short-echo tags * #400: Correct AJAX search's matching-product count * #400: Correct PHP warning for missing count * Update readmes/init for v3.7.1 release * #401: Correcting AJAX search's search-results-count * Update tpl_shipping_estimator.php (#402) Fixing mislabeled id for WCAG purposes. (Was still labeled as exampleModalLabel.) * #404: Update last-modified and readme * #405: Use language-constant on modal shipping-estimator (#406) * #405: Use language constant for modal shipping-estimator * Use short-echo tags * #407: Reformatting shipping-estimator display (#408) * Quick return if nothing in the cart * Only display heading when inline ... ... and consolidate for logged-in/not-logged-in conditions. * Move `$totalsDisplay` to common processing * Apply 2-columns to md+ displays, use xl modal * Refactoring ... - Using short-echo tags - Combine `isset` values - Use null-coalesce where appropriate * Update readme.html, too * #409: AJAX search, update to search in products' descriptions * Adjusting spacing (#403) Per lat9's comment, adjusted the alignment of the HTML surrounding the PHP conditionals. Code will now render properly spaced HTML code. Also went ahead to adjust the update quantity box itself to align correctly with the other HTML source. Update tpl_shopping_cart_default.php Hides the Update Cell in the Shopping Cart unless the option `SHOW_SHOPPING_CART_UPDATE` is specifically set to `Next to each Qty Box` or `Both Next to each Qty Box and Below all Products`. Adding an aria-header to the empty action cells This should make it "visible" to screen readers and assistive devices but invisible to non-users. * #410: Update readme, slight reformatting * #409: Adding config setting to control AJAX search location (#412) * #409: Adding config setting to control AJAX search location ... i.e. whether/not to also search within the descriptions. * Using short-echo tags * #413: Remove pre-zc158 handling from AJAX search * #414: Correct pricing not displayed for PHP 7.4 * Update readmes/init for v3.7.2 release * #417: Ensure that AJAX search keywords are of `string` type * #419: Shipping estimator display shipping-module errors (#420) * Start with some refactoring - Replace `for` loops with `foreach` ones * Display shipping-module error in shipping estimator * #419: Update readme * #419: Update template file's last updated version * #419: Correcting ` ` to ` ` and a simplification Issue noted in now-deleted commit * #386: Use `$template` to locate site_specific_styles.php (zc201+ only) * #422: Split CSS/JS loading out of `html_header.php` (#423) * #422: Split out CSS/JS loading from html_header.php * Refactor/reformat html_header.php - Start in column 1; 4-space indentation - Remove redundant clause in `$lng` initialization check - Make hreflang's link generation more readable. * #411: Add zc210 notification to `tpl_account_history_info_default.php` * Remove usage of `ezpages::page_is_ssl`; zc210 interoperability (#427) * Remove use of `ezpages::page_is_ssl` * Use short-echo tags * Update readme * #316: No back-to-top on small/medium viewports (#430) * #316: Don't display back-to-top on sm/md viewports * Minor refactoring - Use exactly-equal-to where possible - HTML `id` before `class` attribute * Use short-echo tags * Incorporate ezpages status_mobile in offcanvas template One possible solution retaining backward-compatible support. * #432: Correcting notifications/manufacturers-info layout inconsistencies (#433) * Correct inconsistencies * ... and reformatting/refactoring - Use short-echo tags - Use short-array syntax - Split long-ish lines * #432: Add changed files to readme * #428: Update readme to note the change * #434: Correcting various background bleed-throughs on cards * #435: Correct "Centerbox Background Color" application * #421: Using zc210 restructuring for `order_status` page's template (#424) * Initial update ... - Definition name changes; using variables to determine sections' display - Pick up HTML `id` parameters for a couple of the tables; included in the base ZC's version. * Using short-echo tags and ... - Update `nl2br` to use HTML5 `<br>`s - Split a couple of long lines for readability. * #421: Update readme to identify changed file * #429: Adding support for zc210's "Featured Categories" * Update readmes/init for v3.7.3 release * Identify source of the 'tinycolors' javascript * #438: Identify change in readme; update version installed * #439: Update matching-heights jscript to v0.7.2 * #268: Correct product-listing image 'overflow'. * #438: Update for zc210's banners_on_ssl * Add new notifiers from ZC v2.1.0 Ref: zencart/zencart@5c9831c * #444: Update readme, module last-updated * Colors configuration_group should not be visible Since there's an Admin `Tools` menu entry for editing colors, which is more user-friendly than the default `configuration` version of the page, that Group should be set as `not visible`. It's not showing up in the list due to a side-effect of not registering the Group as an authorized Admin page. But for thoroughness it should be set to `0` Undecided whether it's important to address on an upgrade, so didn't PR that. * #442: Correct product-price entry width on listings. * #446: Set the color-setting's configuration group to not-visible * #447: Correct best-sellers' sidebox display * Add notifications to `account_history_info` template's status history table (#449) * #448: Adding OSH notifications to account_history_info The actual change. Some refactoring coming next. * Refactoring - Use short-echo tags - Split longish lines * Update readme to reflect change, * #448: Update to reflect base change ... following the bouncing ball. * Additional notifier added to `tpl_footer.php` (#451) * Add the notification * Refactoring/reformatting tpl_footer.php Similar changes as the base zc210 PR. * #452: Add soft setting for FA brands' icons load * Update readmes/init for v3.7.4 release --------- Co-authored-by: John <dbltoe@users.noreply.github.com> Co-authored-by: brittainmark <gitbrit@inner-light.co.uk> Co-authored-by: Steve <4391026+torvista@users.noreply.github.com> Co-authored-by: Chris Brown <code@drbyte.dev> Co-authored-by: Scott Wilson <scottcwilson@hey.com> Co-authored-by: pRose on charmes <prose@rossroberts.com> Co-authored-by: Paul Williams <retched@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue #246 prompted me to do some investigating into the navbar button coloring.
I found that the
ZCA_HEADER_NAVBAR_BUTTON_*colors were applied only tonav.navbar .navbar-togglerandnav.navbar .navbar-toggler:hover(the hamburger menu button). The non-AJAX header search form's submit button is currently colored by theZCA_BUTTON_*colors, but could be colored by theZCA_HEADER_NAVBAR_BUTTON_*colors by adding the following in the appropriate places in includes/templates/bootstrap/css/stylesheet_zca_colors.php:nav.navbar .btn,beforenav.navbar .navbar-togglernav.navbar .btn:hover,beforenav.navbar .navbar-toggler:hoverThe text was updated successfully, but these errors were encountered: