Skip to content

Ayush/ls#20

Merged
ayushkamat merged 19 commits into
mainfrom
ayush/ls
Mar 6, 2022
Merged

Ayush/ls#20
ayushkamat merged 19 commits into
mainfrom
ayush/ls

Conversation

@ayushkamat
Copy link
Copy Markdown
Contributor

No description provided.

@ayushkamat ayushkamat marked this pull request as ready for review March 5, 2022 21:16
@ayushkamat ayushkamat requested a review from kennyworkman March 5, 2022 21:16
Comment thread latch/cli/main.py Outdated
@click.command("ls")
@click.argument("remote_directories", nargs=-1)
def ls(remote_directories: str):
"""Copy local files to LatchData and vice versa.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong docstring

Comment thread latch/cli/main.py Outdated

@click.command("ls")
@click.argument("remote_directories", nargs=-1)
def ls(remote_directories: str):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote_directory singular

Comment thread latch/cli/main.py Outdated

@click.command("ls")
@click.argument("remote_directories", nargs=-1)
def ls(remote_directories: str):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make Union[None, str]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more legible

Comment thread latch/cli/main.py
"""
_item_padding = 3

if not remote_directories:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then do explicit none check

Comment thread latch/cli/main.py
if not remote_directories:
remote_directories = ["latch:///"]

_initial_padding = 0 if len(remote_directories) < 2 else 3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont understand this, add a comment or something

Comment thread latch/cli/main.py Outdated
header_content_size_padding = max_lengths["content_size"] - len("Size")
header_modify_time_padding = max_lengths["modify_time"] - len("Last Modified")

header = (
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use f-string for legilbility

@ayushkamat ayushkamat merged commit 9b218dd into main Mar 6, 2022
@ayushkamat ayushkamat deleted the ayush/ls branch March 24, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants