big cleanup/fixes#294
Merged
Merged
Conversation
Signed-off-by: maximsmol <maximsmol@gmail.com>
Signed-off-by: maximsmol <maximsmol@gmail.com>
kennyworkman
approved these changes
Jul 6, 2023
| serialize_jit_register_workflow( | ||
| jit_wf, ctx.pkg_root, ctx.snakefile, tmp_dir, image_name, ctx.dkr_repo | ||
| ) | ||
| assert jit_wf is not None |
Member
There was a problem hiding this comment.
i dont understand the asserts, why not check values and throw a more descriptive error, AssertionError tells me nothing (also you can run python without asserts but not as relevant)
| task_td = stack.enter_context(MaybeRemoteDir(ctx.ssh_client)) | ||
| try: | ||
| build_and_serialize( | ||
| _build_and_serialize( |
Member
There was a problem hiding this comment.
I got rid of the underscore for hidden function names because we were using them inconsistent and it makes things harder to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.