Merged
Conversation
Contributor
ibraheem-abe
commented
Aug 30, 2024
ibraheem-abe
commented
- Removes check-swap as it is not available
- UI changes to all remaining commands
- fixes get_weights
- incomplete fix of set_id
thewhaleking
previously approved these changes
Aug 30, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Overall good. I would like for the import order corrected but it's fine for the time being
| render_table, | ||
| update_metadata_table, | ||
| ) | ||
| from bittensor_wallet import Wallet |
Contributor
There was a problem hiding this comment.
These should not be moved to here
thewhaleking
approved these changes
Aug 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.