Merged
Conversation
Contributor
thewhaleking
commented
Aug 30, 2024
thewhaleking
commented
- not required SSH key for btwallet
- config error where network being specified but not chain would result in using finney
- correctly check value instead of SCALE type
- u16 normalise take for DelegateInfo
- get-identity command working
- set-identity command working (also better UX)
…thus could never be None. Instead use `my_uid.value`, which will be None. Consistent with root slash
…a network is specified in config. Fix 0% when previous stake is 0 and current stake is also 0.
thealligatorking
approved these changes
Aug 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.