Merged
Conversation
Contributor
ibraheem-abe
commented
Sep 4, 2024
ibraheem-abe
commented
- Groups v-permits together based on ranges
- Fully displays ss58 address
- Changes table to a box
- Other UI improvements
thewhaleking
requested changes
Sep 4, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
The logic here is a bit weird to follow, and I'd like to see the readability and general flow improved. We shouldn't need so many comments explaining what is happening in the logic, and yet without them, the logic here needs explanation. I think you can improve this.
thewhaleking
approved these changes
Sep 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.