Config + wallet_ask rework, enhancements, fixes#66
Merged
ibraheem-abe merged 4 commits intofix/thewhaleking/raj-fixesfrom Sep 12, 2024
Merged
Config + wallet_ask rework, enhancements, fixes#66ibraheem-abe merged 4 commits intofix/thewhaleking/raj-fixesfrom
ibraheem-abe merged 4 commits intofix/thewhaleking/raj-fixesfrom
Conversation
ibraheem-abe
changed the title
thewhaleking
approved these changes
Sep 12, 2024
| wallet_hotkey: Optional[str], | ||
| validate: bool = True, | ||
| ask_type: str = "name" | ||
| ask_for: List[str] = [], |
Contributor
There was a problem hiding this comment.
why is this List rather than list?
ibraheem-abe
added a commit
that referenced
this pull request
Sep 12, 2024
* Added an ask type in wallet_ask to specify which aspect of the wallet to prompt users for * Warns user if setting chain to non-chain address in config. * Config + wallet_ask rework, enhancements, fixes (#66) * Enhancements and fixes * Removes wallet_name_req and wallet_hk_req * Changes type and adds config for wallet balance * Removes unused import * Fixes different quotes in same line * Removes old wallet_nam_req * Fixes overview bug + tests --------- Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WalletOptionsandWalletValidationTypeswallet_name_reqandwallet_hk_req