fix: thread --announce-only through stake/liquidity/crowd submission paths

[bitloi]

Closes #898

--announce-only was accepted at the CLI layer but dropped on multiple stake/liquidity/crowd paths before extrinsic submission.

This change:

• threads announce_only from CLI handlers into downstream command functions
• passes announce_only to sign_and_send_extrinsic / sign_and_send_batch_extrinsic
• fixes the interactive unstake -> unstake_all path to forward proxy + announce_only
• keeps announce-only behavior consistent by disabling MEV shielding when announcing
• adds regression tests for CLI forwarding and command-level forwarding across stake, liquidity, and crowd flows

[bitloi]

@ibraheem-abe Thanks for your review. I just fixed the conflict, would you please review this PR as well?

[thewhaleking]

LGTM but want @ibraheem-abe to verify

[ibraheem-abe]

The forwarding looks right to me, but I think the success UX is still a bit off for --announce-only.

In that mode we’re only submitting Proxy.announce, not actually executing the underlying stake/liquidity/crowd call yet.
Execution only happens later.

Some of these paths still seem to report success as if the real action already happened, which feels misleading.
(For example, stake added, crowdloan funded etc)

Ideally we should branch the success handling for announce_only=True so we say “announcement submitted” instead of showing finalized-style messaging for the underlying operation (Eg: Stake added, Stake removed).

A disclaimer might be useful too in cases where we interact with staking calls and show the slippage table etc
(eg: this is the expected receivable xyz right now; not guaranteed when the call actually executes)

@thewhaleking wdyt

[thewhaleking]

The forwarding looks right to me, but I think the success UX is still a bit off for --announce-only.

In that mode we’re only submitting Proxy.announce, not actually executing the underlying stake/liquidity/crowd call yet. Execution only happens later.

Some of these paths still seem to report success as if the real action already happened, which feels misleading. (For example, stake added, crowdloan funded etc)

Ideally we should branch the success handling for announce_only=True so we say “announcement submitted” instead of showing finalized-style messaging for the underlying operation (Eg: Stake added, Stake removed).

A disclaimer might be useful too in cases where we interact with staking calls and show the slippage table etc (eg: this is the expected receivable xyz right now; not guaranteed when the call actually executes)

@thewhaleking wdyt

Now that you mention it, that is probably why I didn't fully implement this.

[ibraheem-abe]

The forwarding looks right to me, but I think the success UX is still a bit off for --announce-only.
In that mode we’re only submitting Proxy.announce, not actually executing the underlying stake/liquidity/crowd call yet. Execution only happens later.
Some of these paths still seem to report success as if the real action already happened, which feels misleading. (For example, stake added, crowdloan funded etc)
Ideally we should branch the success handling for announce_only=True so we say “announcement submitted” instead of showing finalized-style messaging for the underlying operation (Eg: Stake added, Stake removed).
A disclaimer might be useful too in cases where we interact with staking calls and show the slippage table etc (eg: this is the expected receivable xyz right now; not guaranteed when the call actually executes)
@thewhaleking wdyt

Now that you mention it, that is probably why I didn't fully implement this.

Should effort be made to add this branching right now or during/after V10?
We probably need to handle this cmd to cmd basis as well if we wanna have a great UX for this module.

[bitloi]

@thewhaleking @ibraheem-abe Do you want me to add announce-only success messaging in this PR or as a follow-up?

[thewhaleking]

@ibraheem-abe raises a good point. Because of the large refactor this is going to require, I think we'll hold off on this until v10. Adding it to the RFC.

[thewhaleking]

@bitloi if you want to salvage this PR until we implement this in v10, instead just remove all the --announce-only args of cli.py methods which take them (e.g. the ones in here where you added the passthrough of those args).

[bitloi]

@bitloi if you want to salvage this PR until we implement this in v10, instead just remove all the --announce-only args of cli.py methods which take them (e.g. the ones in here where you added the passthrough of those args).

Okay, I will update soon.

[bitloi]

Ready for review! @thewhaleking