CONT-133: add support for political contributions#114
Merged
Conversation
kamni
commented
Mar 8, 2018
| url = self.lp.get_buy_url(item) | ||
| self.assertTrue(url.startswith('https://web.laterpay.net/dialog/contribute/pay_now?')) | ||
| self.assertQueryString(url, 'campaign_id', value='2') | ||
| self.assertQueryString(url, 'campaign_id', value='save-the-world') |
Contributor
Author
There was a problem hiding this comment.
'save-the-world' is the correct value. However, the tests pass, regardless of what the value is here. Something isn't right.
MarkusH
reviewed
Mar 12, 2018
Contributor
MarkusH
left a comment
MarkusH
left a comment
There was a problem hiding this comment.
One minor change I'm going to make. Otherwise LGTM.
|
|
||
| def __init__(self, item_id, pricing, url, title, expiry=None, sub_id=None, period=None, item_type=None): | ||
| def __init__(self, item_id, pricing, url, title, expiry=None, sub_id=None, | ||
| period=None, election_id=None, item_type=None): |
Contributor
There was a problem hiding this comment.
I'm moving election_id to the end to preserve the ordering of the existing parameters. Even if they are all named arguments.
MarkusH
force-pushed
the
feature/CONT-133_political-contributions
branch
from
9ee2a8f to
8b0f2a0
Compare
MarkusH
force-pushed
the
feature/CONT-133_political-contributions
branch
from
8b0f2a0 to
74dc0b2
Compare
MarkusH
approved these changes
Mar 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for political contributions to the laterpay python client. Political contributions add an
election_idas a new parameter, in addition to the new API endpoints.