Stopped validating period in ItemDefinition #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slafs
previously requested changes
May 7, 2018
Member
slafs
left a comment
slafs
left a comment
There was a problem hiding this comment.
I missed the reason for such change. Why we don't want to validate that parameter here?
| @@ -1,6 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 5.9.0 (under development) | |||
Member
There was a problem hiding this comment.
isn't 5.9.0 still "under development"?
Contributor
Author
There was a problem hiding this comment.
I only plan on making this one commit for the next release. I was planning on tagging the merged commit. But I just realized I'd need to update the setup.py as well. I'll revert this line. Thanks!
CHANGELOG.md
Outdated
| ## 5.9.0 | ||
|
|
||
| * The `ItemDefinition` does not validate the bounds for `period` any longer. | ||
| This has to be don't by the integrating party. This is along the lines of |
Member
There was a problem hiding this comment.
I think you meant s/don't/done/, right?
suligap
approved these changes
May 8, 2018
This is along the lines of what is happening with `expiry` when using time passes. This is also eases the way of integrating LaterPay as this bounding library does not need to be 100% up to date with what our platform supports. CONNECTOR-1151
MarkusH
force-pushed
the
dont-validate-subs-period
branch
from
e8aeb6f to
db9a8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is along the lines of what is happening with
expirywhen usingtime passes. This is also eases the way of integrating LaterPay as
this bounding library does not need to be 100% up to date with what
our platform supports.
CONNECTOR-1151