Skip to content

Discard None params in LaterPayClient._get_web_url() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haraball merged 2 commits into from
Oct 16, 2014
Merged

Discard None params in LaterPayClient._get_web_url() #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e618c9d
Added a regression test for expiry param equal to 'None'.
Oct 10, 2014
dad3341
Discard `None` params in `LaterPayClient._get_web_url()`
Oct 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions laterpay/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# -*- coding: utf-8 -*-
from __future__ import absolute_import, print_function

import copy
import json
import logging
import random
Expand Down Expand Up @@ -231,7 +230,8 @@ def _get_web_url(self,
transaction_reference=None,
consumable=False):

data = copy.copy(item_definition.data)
# filter out params with None value.
data = {k: v for k, v in item_definition.data.items() if v is not None}

if use_jsevents:
data['jsevents'] = 1
Expand Down
9 changes: 9 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,15 @@ def test_transaction_reference(self):
use_jsevents=True,
transaction_reference='123')

def test_get_web_url_has_no_none_params(self):
# item with expiry not set.
item = ItemDefinition(1, 'EUR20', 'DE19.0', 'http://help.me/', 'title')
url = self.lp.get_add_url(item)
self.assertFalse(
'expiry%3DNone' in url,
'expiry url param is "None". Should be omitted.',
)


if __name__ == '__main__':
unittest.main()