feat(install): add shared skill install workflow and cobra adapter#3
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ce369d187
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if exit.OK || exit.Code == "canceled" { | ||
| return nil |
There was a problem hiding this comment.
Return an error when the workflow is canceled
When an interactive user cancels at the confirmation prompt or submits an empty multi-select, ClassifyInstallWorkflowExit marks the workflow as OK: false with code canceled, but this helper swallows that state and returns nil. The new Cobra adapter returns InstallWorkflowError(report) directly, so a canceled install exits successfully instead of signaling cancellation to the CLI caller; return the canceled message as an error (or have the adapter use the classifier) rather than treating it as success.
Useful? React with 👍 / 👎.
Summary
Adds a shared bundled skill install workflow across TypeScript, Go, and Rust, including standard flag parsing, scope and agent selection, confirmation handling, structured exit helpers, embedded bundle support, and a thin optional Go Cobra adapter.
Scope Check
spec/hosts.jsonchanges.Verification
make check