Skip to content

feat(install): add shared skill install workflow and cobra adapter#3

Merged
samzong merged 1 commit into
mainfrom
feat/install-workflow
Jun 29, 2026
Merged

feat(install): add shared skill install workflow and cobra adapter#3
samzong merged 1 commit into
mainfrom
feat/install-workflow

Conversation

@samzong

@samzong samzong commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a shared bundled skill install workflow across TypeScript, Go, and Rust, including standard flag parsing, scope and agent selection, confirmation handling, structured exit helpers, embedded bundle support, and a thin optional Go Cobra adapter.

Scope Check

  • Stays within the v0.1 bundled-skill installer boundary.
  • Does not add marketplace, registry, remote install, script execution, GUI, MCP server, or agent runtime behavior.
  • Updates golden cases for observable installer behavior changes.
  • Regenerates host constants after spec/hosts.json changes.

Verification

  • make check

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong merged commit 3b77439 into main Jun 29, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ce369d187

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go/kitup.go
Comment on lines +186 to +187
if exit.OK || exit.Code == "canceled" {
return nil

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Return an error when the workflow is canceled

When an interactive user cancels at the confirmation prompt or submits an empty multi-select, ClassifyInstallWorkflowExit marks the workflow as OK: false with code canceled, but this helper swallows that state and returns nil. The new Cobra adapter returns InstallWorkflowError(report) directly, so a canceled install exits successfully instead of signaling cancellation to the CLI caller; return the canceled message as an error (or have the adapter use the classifier) rather than treating it as success.

Useful? React with 👍 / 👎.

@samzong samzong deleted the feat/install-workflow branch July 1, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant