feat(skill): bundle generated skill installs#89
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 488d6d0729
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if a.Skill == nil { | ||
| return nil | ||
| return render.RemoveSkillBundlePackage() |
There was a problem hiding this comment.
When sources.yaml contains a source key named skillbundle and Skill bundling is disabled (the default), the loop above renders that API module into internal/generated/skillbundle, then this cleanup removes the same directory and leaves modules_gen.go importing a package that no longer exists. Source names are not rejected in sourceconfig, so an existing module with this otherwise-valid name is broken by a normal lathe codegen; reserve/validate the name or put the bundle package somewhere that cannot collide with source modules.
Useful? React with 👍 / 👎.
1 participant
No description provided.