Fix/loose config schema type #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8bc5bc.
andresgutgon
commented
Oct 2, 2025
| private withParameters?: string[] | ||
| private requireConfig: boolean | ||
| private configSchema?: z.ZodType | ||
| private configSchema?: z.ZodTypeAny |
Contributor
Author
There was a problem hiding this comment.
This is the only change in this PR. The rest is downgrading this package to zod v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Passing a nested deep Zod schema to
scanresults in poor TypeScript performance. I'm trying to loosen up.Note
Previous version bumped zod to v4 but I cant do this before fixing this problem