Skip to content

Allow updating to hackney 4.x#168

Open
cheerfulstoic wants to merge 2 commits into
lau:masterfrom
cheerfulstoic:patch-1
Open

Allow updating to hackney 4.x#168
cheerfulstoic wants to merge 2 commits into
lau:masterfrom
cheerfulstoic:patch-1

Conversation

@cheerfulstoic
Copy link
Copy Markdown

Just saw this post:

“A bunch of vulnerabilities I reported in hackney were just disclosed. Please upgrade to 4.0.1 ASAP. I know this is gonna start dependency hell so please take some time for this. Please repost for reach. #ElixirLang”

https://www.linkedin.com/feed/update/urn:li:activity:7464785377061605376/?utm_source=share&utm_medium=member_desktop&rcm=ACoAAAEtYLIBXsVotWn8wDbLS0eyvk4VDJxtCoc

Just saw this post:

“A **bunch** of vulnerabilities I reported in hackney were just disclosed. Please upgrade to 4.0.1 ASAP. I know this is gonna start dependency hell so please take some time for this. Please repost for reach. #ElixirLang”

https://www.linkedin.com/feed/update/urn:li:activity:7464785377061605376/?utm_source=share&utm_medium=member_desktop&rcm=ACoAAAEtYLIBXsVotWn8wDbLS0eyvk4VDJxtCoc
@jgelens
Copy link
Copy Markdown

jgelens commented May 27, 2026

The Hackney:get api also changed, so you will have to update that as well and disallow the older versions.

@cheerfulstoic
Copy link
Copy Markdown
Author

Good point, I was mainly just trying to kick things into gear. But I'd like to make it as easy as possible to move forward, so I had claude make this change. But I guess @lau will need to figure out the versions that are released still

Comment thread mix.exs Outdated
geekingfrog added a commit to beyond-all-reason/teiserver that referenced this pull request May 28, 2026
there was a bunch of vulnerabilitie from hackney and tzdata relies on
hackney to download latest iana zone info.
So we upgraded hackney #1191
but that led to #1198

So update tzdata to point to an unmerged PR:
lau/tzdata#168
that upgrades hackney and changes the code for the new hackney API.
This dependency should not stay as is, ideally we can point to hex.pm
new version once tzdata has been updated with this fix.

This can be tested by firing up a shell:

```elixir
Tzdata.DataLoader.download_new()
Tzdata.tzdata_version()  # 2026b at time of commit
```
geekingfrog added a commit to geekingfrog/tzdata that referenced this pull request May 29, 2026
This is the same (as time of commit) from
lau#168
however, that PR can change, and the commit sha may be overwritten.

So this fork and commit is there so our builds don't break because of
changes out of our control.
All of this should be temporary, hopefully we can soon rely on a stable
version of tzdata on hex.pm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants