Conversation
…with CARGO_MANIFEST_DIR-relative paths in session_process tests
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Shooksie
added a commit
that referenced
this pull request
Apr 1, 2026
…FEST_DIR Same root cause as #199 — tests used hardcoded /Users/samishukri/ao-cli/ paths for fixture files. Use concat!(env!("CARGO_MANIFEST_DIR"), ...) so tests pass regardless of checkout location. Fixes 3 failing tests: claude, codex, and gemini backend fixture tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Shooksie
added a commit
that referenced
this pull request
Apr 1, 2026
…FEST_DIR (#200) Same root cause as #199 — tests used hardcoded /Users/samishukri/ao-cli/ paths for fixture files. Use concat!(env!("CARGO_MANIFEST_DIR"), ...) so tests pass regardless of checkout location. Fixes 3 failing tests: claude, codex, and gemini backend fixture tests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 1, 2026
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Shooksie
added a commit
that referenced
this pull request
Apr 8, 2026
…ST_DIR in session_process tests (#199) * fix(agent-runner): replace hardcoded /Users/samishukri/ao-cli/ paths with CARGO_MANIFEST_DIR-relative paths in session_process tests * style: fix rustfmt formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Shooksie
added a commit
that referenced
this pull request
Apr 8, 2026
…FEST_DIR (#200) Same root cause as #199 — tests used hardcoded /Users/samishukri/ao-cli/ paths for fixture files. Use concat!(env!("CARGO_MANIFEST_DIR"), ...) so tests pass regardless of checkout location. Fixes 3 failing tests: claude, codex, and gemini backend fixture tests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/agent-runner/src/runner/session_process.rshad hardcoded/Users/samishukri/ao-cli/absolute paths for fixtures and theaobinaryconcat!(env!("CARGO_MANIFEST_DIR"), "/<relative-path>")so tests work on any developer machine/../llm-cli-wrapper/tests/fixtures/<name>.jsonl(one level up fromagent-runnertocrates/, then intollm-cli-wrapper/)/../../target/debug/ao(two levels up to workspace root)spawn_session_process_passes_claude_mcp_launch_args_and_preserves_primary_serverupdated to match the new variable-based inputsTests
All 113
agent-runnertests pass:cargo test -p agent-runner