fix(orchestrator-cli): recover from poisoned env lock in tests#202
Merged
fix(orchestrator-cli): recover from poisoned env lock in tests#202
Conversation
Replace .expect() with .unwrap_or_else(|p| p.into_inner()) on all test_env_lock() acquisitions. A panicking test previously poisoned the shared Mutex, causing 33 unrelated tests to cascade-fail. Fixes #201 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 1, 2026
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Shooksie
added a commit
that referenced
this pull request
Apr 8, 2026
Replace .expect() with .unwrap_or_else(|p| p.into_inner()) on all test_env_lock() acquisitions. A panicking test previously poisoned the shared Mutex, causing 33 unrelated tests to cascade-fail. Fixes #201 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.lock().expect(...)with.lock().unwrap_or_else(|p| p.into_inner())on alltest_env_lock()call sites across 13 files inorchestrator-clistd::sync::Mutexbecomes poisoned. The previous.expect()calls caused every subsequent test to also panic, turning 1 real failure into 34 cascade failuresTest plan
cargo fmt -p orchestrator-cli— cleancargo clippy -p orchestrator-cli— no new warningscargo test -p orchestrator-cli— 272 passed, 1 failed (pre-existingdaemon_run_emits_task_state_change_events, unrelated to this change)Fixes #201
🤖 Generated with Claude Code