fix(lint): resolve all clippy warnings workspace-wide#207
Merged
Conversation
- Rename deprecated `option_map_unwrap_or`/`option_map_unwrap_or_else` lints
to `map_unwrap_or` in workspace Cargo.toml
- Fix `lines_filter_map_ok`: replace `.flatten()` with `.map_while(Result::ok)`
in orchestrator-logging and orchestrator-cli
- Fix `unnecessary_map_or`: use `is_none_or` in orchestrator-logging filters
- Fix `redundant_pattern_matching`: use `.is_err()` in protocol
- Fix `needless_return`: remove bare `return` in agent-runner lock
- Add `Default` impls for `Supervisor` and `RunnerMetrics` in agent-runner
- Fix `bool_comparison`: use `!expr` instead of `expr == false` in protocol
- Fix `needless_question_mark`: unwrap `Ok(x?)` to `x` in orchestrator-core
- Fix `collapsible_if` and `explicit_iter_loop` in oai-runner agent_loop
- Fix `unnecessary_cast` and `unnecessary_unwrap` in oai-runner
- Fix `unnecessary_lazy_evaluations`: use `unwrap_or` in workflow-runner-v2
- Fix `single_char_add_str`: use `push('\n')` in ops_now
- Remove unused imports in ops_queue and ops_workflow test modules
- Suppress intentional `await_holding_lock` in test modules that use a
std Mutex for test serialization (env locks), not for async coordination
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 1, 2026
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Shooksie
added a commit
that referenced
this pull request
Apr 8, 2026
All CI checks pass. Lint cleanup - zero clippy warnings workspace-wide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --workspace --all-targetswarnings — zero warnings remainingcargo fmt --checkpasses clean throughoutChanges
Cargo.toml: Updated renamed lints
option_map_unwrap_or/option_map_unwrap_or_else→map_unwrap_orCode fixes across 23 files:
lines_filter_map_ok:.flatten()→.map_while(Result::ok)(orchestrator-logging, orchestrator-cli)unnecessary_map_or:.map_or(true, ...)→.is_none_or(...)(orchestrator-logging)redundant_pattern_matching:if let Err(_) = ...→.is_err()(protocol)needless_return: removed barereturnin last match arm (agent-runner)new_without_default: addedDefaultimpls forSupervisorandRunnerMetrics(agent-runner)bool_comparison:== false→!expr(protocol)needless_question_mark:Ok(x?)→x(orchestrator-core)collapsible_if,explicit_iter_loop,unnecessary_cast,unnecessary_unwrap(oai-runner)unnecessary_lazy_evaluations:unwrap_or_else(|| x)→unwrap_or(x)(workflow-runner-v2)single_char_add_str:push_str("\n")→push('\n')(orchestrator-cli ops_now)#![allow(clippy::await_holding_lock)]to 8 test modules that intentionally hold astd::Mutexenv-lock across awaits for test serializationTest plan
cargo fmt --check— cleancargo clippy --workspace --all-targets— zero warnings🤖 Generated with Claude Code