fix: use sqlite3_value_text for REGEXP to match SQLite coercion#4203
Open
joaquinhuigomez wants to merge 1 commit intolaunchbadge:mainfrom
Open
fix: use sqlite3_value_text for REGEXP to match SQLite coercion#4203joaquinhuigomez wants to merge 1 commit intolaunchbadge:mainfrom
joaquinhuigomez wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
Use sqlite3_value_text() instead of checking sqlite3_value_type() first, matching SQLite's documented text affinity coercion for the REGEXP operator. NULL values still return NULL. Closes launchbadge#4190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REGEXPimplementation rejects non-TEXT values by checkingsqlite3_value_type()before callingsqlite3_value_text(). This means123 REGEXP '23'returns NULL instead of matching.Per the SQLite docs, calling
sqlite3_value_text()on INTEGER/REAL/BLOB values coerces them to their text representation. This change removes the type check (except for NULL) and lets SQLite handle the coercion, matching the behavior users expect fromX REGEXP Yon non-TEXT columns.Added test covering INTEGER, REAL, INTEGER column, and NULL cases.
Closes #4190