feat: support for prereleases#80
Conversation
bryce-lynn-nttd
left a comment
There was a problem hiding this comment.
PR Review
Overall: This is the clean unblocker for launch-terraform-skeleton#20 — landing the feat/prerelease-on-merge work on main so callers can pin to a real tag rather than a feature-branch ref. Adds prerelease_identifier and publish inputs to reusable-release-on-merge.yml, threads both into the existing release-drafter@6a93d829 step (replacing the previously-hardcoded publish: true), removes the unused run_post_release_workflow input, and adds a clear docs section walking through the rc0 → rc1 → draft-rename cycle.
Verifications:
release-drafter@6a93d829supports both new inputs. Confirmedprerelease-identifier(line 46) andpublish(line 31) on itsaction.ymlat the pinned SHA.- No callers of the removed
run_post_release_workflowinput outside this file. Org-wide code search returned only the file being modified. - Only existing caller of
prerelease_identifierin the org islaunch-terraform-skeleton/.github/workflows/prerelease-on-merge.yml— exactly the file currently broken on skeleton PR #20. - Defaults preserved:
publish: truematches the previous hardcoded behavior, so all existing callers (the template-distributedrelease-publish.ymlin module repos and the eight launch-terraform-skeleton workflow refs) keep working without changes.
CI green; no prior reviews.
Non-blocking
-
Commit type could arguably be
feat!:rather thanfeat:. Removingrun_post_release_workflowis technically a breaking change to the workflow's input contract — any future caller passing that input would hitstartup_failure(we empirically verified that behavior yesterday in a sandbox). Practically harmless because no consumers exist today, but a strict reading of Conventional Commits would mark thisfeat!:. Your call; the PR body discloses the removal clearly so I wouldn't pedantic-block on this. -
Disposition of skeleton PR #20. Once this lands and a tag is cut, the path forward there is either (a) update PR #20 in place to repoint
prerelease-on-merge.ymlat the new SHA, or (b) close it and open a fresh PR with the corrected reference. Worth a one-line note on PR #20 once the tag exists so the chain is visible.
Generated with Claude Code (Opus 4.7)
|
1 is intentional, I'm going to purposefully bump the major version at the end of all of this. |
Missed this in a prior update. Adds support for the prerelease functionality we're using in launch-terraform-skeleton.
Drops run_post_release_workflow, which never got implemented and isn't used by any callers.