fix(experiments): require a winning variation when stopping an iteration#71
Merged
Merged
Conversation
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
mabramowitz-pixel
approved these changes
May 29, 2026
erangeles
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
launchdarkly-experiment-setupskill told the model it could stop an experiment iteration with "no winner declared." In practice LaunchDarkly requires you to declare a winning variation to stop an iteration, so that guidance led to failed stops.This updates the skill so that stopping always declares a
winningTreatmentId(andwinningReason). When an experiment is inconclusive, the guidance is to declare the baseline/control as the winner — there is no "stop without a winner" path.Paired with a fix to the
stop-experiment-iterationMCP tool in gram-functions that makeswinningTreatmentIdrequired.Testing approaches
Skill-only doc change; reviewed against the actual
stop-experiment-iterationtool behavior.Feature flags
N/A