chore: adds DataSystem and FDv2 contract test service functionality#341
chore: adds DataSystem and FDv2 contract test service functionality#341tanderson-ld merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
"events/disabling" was skipped, but it is supported and has been for some time. I have updated it to not skip this.
| -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/main/downloader/run.sh \ | ||
| | VERSION=v2 PARAMS="-url http://localhost:8001 -host 10.0.2.2 -skip-from testharness-suppressions.txt -debug $(TEST_HARNESS_PARAMS)" sh | ||
| -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/v2/downloader/run.sh \ | ||
| | VERSION=v2 PARAMS="-url http://localhost:8001 -host 10.0.2.2 -debug -stop-service-at-end -skip-from $(SUPPRESSION_FILE) $(TEST_HARNESS_PARAMS_V2)" sh |
There was a problem hiding this comment.
For reviewers: The above block will be deleted and replaced with the below block after the below block is uncommented in a future PR.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7b4efaf. Configure here.
contract-tests/src/main/java/com/launchdarkly/sdktest/SdkClientEntity.java
Show resolved
Hide resolved
contract-tests/src/main/java/com/launchdarkly/sdktest/SdkClientEntity.java
Show resolved
Hide resolved
contract-tests/src/main/java/com/launchdarkly/sdktest/Representations.java
Show resolved
Hide resolved
aaron-zeisler
left a comment
aaron-zeisler
left a comment
There was a problem hiding this comment.
Overall it looks good to me. I have a couple curiosity questions, and I think the issue Bugbot pointed out is real.
2 participants
Requirements
I have added test coverage for new or changed functionality
N/A, this is the test coverage.
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Related issues
SDK-1823
Describe the solution you've provided
Adds DataSystem control to the contract test service (this is what the SDK test harness connects to).
Note
Medium Risk
Touches SDK runtime translation of FDv2 flag updates and changes how contract-test clients configure data sources, which could affect flag update behavior and test reliability, but scope is limited and changes are straightforward.
Overview
Enables the Android contract test service to configure the SDK’s new
DataSystem/connection-mode pipelines via test harness JSON, including custom initializers/synchronizers and explicit connection mode selection, falling back to the prior polling/streaming config whendataSystemis not provided.Updates the contract test runner to use the
sdk-test-harnessv2 downloader, adds suppression file plumbing (including a new FDv2 suppression list), and ensures the service is stopped after tests.Fixes FDv2 changeset translation to always use the envelope key when constructing
Flagobjects, avoiding reliance on inner JSON that omitskey.Reviewed by Cursor Bugbot for commit d954bbf. Bugbot is set up for automated code reviews on this repo. Configure here.