chore: enable FDv2 contract tests via sdk-test-harness v3.1.0-alpha.6#367
Merged
tanderson-ld merged 1 commit intoJun 4, 2026
Merged
Conversation
Uncomments the v3 contract-test invocation in the Makefile and pins the harness version to v3.1.0-alpha.6 -- the first published alpha that includes sdk-test-harness PR #325 ("updates so FDv2 tests can run against client side sdks"). The v2 invocation no longer carries -stop-service-at-end (it is no longer the final harness run); the v3 invocation gains the flag so the contract-test service stops cleanly after both suites complete. Verified locally on emulator-5554: v2 (FDv1): 798 total, 14 skipped, 784 ran -- all passed v3 (FDv2, v3.1.0-alpha.6): 784 total, 21 skipped, 763 ran -- all passed SDK-2442
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v3.1.0-alpha.6— the first published alpha that includes sdk-test-harness PR #325 ("updates so FDv2 tests can run against client side sdks").-stop-service-at-endflag from the v2 invocation to the v3 invocation (v3 is now the final harness run).Targets the
sdk-2429-android-fdv2-eapumbrella branch.Tracking: SDK-2442.
Test plan
make build-contract-testssucceeds.make start-contract-test-serviceinstalls and starts the APK on the emulator.make run-contract-testsruns both harnesses cleanly:v3.1.0-alpha.6): 784 total, 21 skipped, 763 ran — all passed.Note
Low Risk
Makefile-only CI/contract-test wiring with no production SDK or runtime behavior changes.
Overview
make run-contract-testsnow runs both harnesses in sequence: v2 (FDv1) unchanged except-stop-service-at-endis removed, then a new v3 step pinned tosdk-test-harness/v3.1.0-alpha.6withSUPPRESSION_FILE_FDV2,TEST_HARNESS_PARAMS_V3, and-stop-service-at-endso the contract test service stops after the final run.The old commented-out v3 block and “uncomment when ready” note are deleted; the Makefile comment still documents that only the last harness should pass
-stop-service-at-end.Reviewed by Cursor Bugbot for commit 54f04b5. Bugbot is set up for automated code reviews on this repo. Configure here.