Stop doing internet things when we don't have internet access. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Log.e(TAG, "Exception when updating flags.", e); | ||
| } | ||
| if (isInternetConnected(context)) { | ||
| final OkHttpClient client = new OkHttpClient.Builder() |
There was a problem hiding this comment.
If we keep the same client object around forever, the connection times out when transitioning from no internet to having internet. Creating a new client with each request removes that problem.
|
👍 |
drichelson
added a commit
that referenced
this pull request
May 18, 2017
UserManager: change listeners now controlled by synchronized block instead of SynchronizedMultiMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop doing internet things when we don't have internet access.