feat: Update windows static builds. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
May 22, 2023
| std::cout << "Reason was: " << *reason << std::endl; | ||
| } | ||
|
|
||
| // Identify a series of contexts. |
There was a problem hiding this comment.
Remove this, because sleep isn't just included in windows.
kinyoklion
commented
May 22, 2023
| find_package(Threads REQUIRED) | ||
|
|
||
| add_executable(hello-cpp main.cpp) | ||
| target_link_libraries(hello-cpp PRIVATE launchdarkly::client launchdarkly::sse launchdarkly::common Threads::Threads) |
There was a problem hiding this comment.
Common being included was causing all kinds of missing symbols, when all those are already in client.
kinyoklion
commented
May 22, 2023
| add_library(launchdarkly::client ALIAS ${LIBNAME}) | ||
|
|
||
|
|
||
| set_property(TARGET ${LIBNAME} PROPERTY |
There was a problem hiding this comment.
We may need to have a more complex version of this eventually. But as is we always dynamically link against the windows runtime. Either the debug or release version.
kinyoklion
changed the title
cwaldren-ld
approved these changes
May 22, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.