feat: Implement context filtering and JSON serialization. #11
Conversation
kinyoklion
changed the title
| class Array { | ||
| public: | ||
| struct Iterator { | ||
| using iterator_category = std::forward_iterator_tag; |
There was a problem hiding this comment.
So we can iterate the array either direction.
| std::vector<std::string> redactions; | ||
|
|
||
| filtered.as_object().emplace("key", attributes.key()); | ||
| if (include_kind) { |
There was a problem hiding this comment.
Conditional for single versus multi-context.
libs/common/src/context_filter.cpp
Outdated
| // An item in an array cannot be marked private. | ||
| stack.push_back(StackItem{ | ||
| *rev_from, std::vector<std::string_view>{}, *nested}); | ||
| *rev_from++; |
|
|
||
| ContextFilter::ContextFilter( | ||
| bool all_attributes_private, | ||
| AttributeReference::SetType const& global_private_attributes) |
There was a problem hiding this comment.
I am again considering if these should be shared pointers.
There was a problem hiding this comment.
Instead of references to global_private_attributes a shared pointer to them. Makes lifetime management easier to have a smart pointer.
| * added to the output object. If the node is complex, then each of its | ||
| * immediately children is added to the stack to be processed. | ||
| */ | ||
| struct StackItem { |
There was a problem hiding this comment.
I generally try to avoid recursive implementations outside functional languages. I have done that here, but I have not specifically benchmarked and compared the stack size and performance between the two implementations.
| return filtered; | ||
| } | ||
|
|
||
| void ContextFilter::append_simple_type(ContextFilter::StackItem& item) { |
There was a problem hiding this comment.
It is possible some of this code may be replaced when I add more JSON support around values.
Implement a ContextFilter which allows for transforming a Context into filtered JSON suitable for events.