feat: add Version method to obtain SDK version #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #204904: Add version method. |
cwaldren-ld
force-pushed
the
cw/sc-204904/version-method
branch
from
821cb8d to
a1f2c06
Compare
kinyoklion
reviewed
May 30, 2023
kinyoklion
approved these changes
May 30, 2023
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
Approved with minor comments.
kinyoklion
approved these changes
May 30, 2023
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
I do think a public static method would be more convenient. Because then you don't need to create a client to know the SDK version.
Contributor
Author
|
Agreed. Will update. |
kinyoklion
reviewed
May 30, 2023
kinyoklion
approved these changes
May 30, 2023
kinyoklion
approved these changes
May 30, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-client-v0.1.0...launchdarkly-cpp-client-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * add Version method to obtain SDK version ([#122](#122)) ([1003117](1003117)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.0 to 0.1.1 * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> <details><summary>launchdarkly-cpp-common: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-common-v0.1.0...launchdarkly-cpp-common-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * Allow for easier creation of contexts from existing contexts. ([#130](#130)) ([5e18616](5e18616)) ### Bug Fixes * rename C iterator bindings to follow new/free pattern ([#129](#129)) ([24dff9a](24dff9a)) </details> <details><summary>launchdarkly-cpp-internal: 0.1.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Version/LDClientSDK_Versionmethod, which exposes the client's version via function call.In the previous way, it was a public static class member. This way, we have a bit more encapsulation and can also expose it via C binding.