feat: add event summarizer #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #194283: Implement common Event processor. |
cwaldren-ld
force-pushed
the
cw/sc-194283/summarizing
branch
from
4d332f1 to
2e4d403
Compare
cwaldren-ld
force-pushed
the
cw/sc-194283/summarizing
branch
from
2e4d403 to
c72fcd6
Compare
cwaldren-ld
commented
Apr 14, 2023
| CheckOptions: | ||
| - { key: readability-identifier-length.IgnoredParameterNames, value: 'i|j|k|c|os|it' } | ||
| - { key: readability-identifier-length.IgnoredVariableNames, value: 'ec' } | ||
| - { key: readability-identifier-length.IgnoredLoopCounterNames, value: 'i|j|k|c|os|it' } |
There was a problem hiding this comment.
boost::system::error_code ec is all over the boost docs.
cwaldren-ld
commented
Apr 14, 2023
cwaldren-ld
force-pushed
the
cw/sc-194283/summarizing
branch
from
62ede03 to
72451cf
Compare
kinyoklion
approved these changes
Apr 17, 2023
This was referenced May 8, 2023
This was referenced May 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event summarizer component to the event processor.
Right now the testing is a bit awkward since the evaluation result/reasons are pretty verbose to write out using constructors (instead of having them be deserialized from JSON like in normal SDK operation.)