fix: allow for specification of initial reconnect delay in streaming data source #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #204393: Use initial reconnect delay for the streaming data source.. |
kinyoklion
reviewed
Aug 31, 2023
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
I feel like there are some todos associated with this.
Member
cwaldren-ld
force-pushed
the
cw/sc-204393/intial-reconnect-delay
branch
from
71987dc to
65dde5e
Compare
Member
|
I think some code should be needed in the streaming data source? |
kinyoklion
approved these changes
Aug 31, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Sep 1, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.0.7</summary> ## [3.0.7](launchdarkly-cpp-client-v3.0.6...launchdarkly-cpp-client-v3.0.7) (2023-08-31) ### Bug Fixes * allow for specification of initial reconnect delay in streaming data source ([#229](#229)) ([d1dde79](d1dde79)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.7 to 0.1.8 * launchdarkly-cpp-common bumped from 0.3.4 to 0.3.5 </details> <details><summary>launchdarkly-cpp-common: 0.3.5</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.1.1 to 0.1.2 </details> <details><summary>launchdarkly-cpp-internal: 0.1.8</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.3.4 to 0.3.5 </details> <details><summary>launchdarkly-cpp-sse-client: 0.1.2</summary> ## [0.1.2](launchdarkly-cpp-sse-client-v0.1.1...launchdarkly-cpp-sse-client-v0.1.2) (2023-08-31) ### Bug Fixes * allow for specification of initial reconnect delay in streaming data source ([#229](#229)) ([d1dde79](d1dde79)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public API was already available, but we didn't have the plumbing required to get it into the SSE client. Therefore, I'm regarding it as a bugfix.
This came up because we need it to pass some streaming contract tests, which in part fail because our default delays are too high (starting at 1 second).