feat: clean up LD CMake variables & allow for OpenSSL dynamic link #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #218523: Allow OpenSSL to be dynamically linked. |
cwaldren-ld
force-pushed
the
cw/sc-218523/openssl-dynamic-link
branch
2 times, most recently
from
444a6a7 to
64c6978
Compare
cwaldren-ld
force-pushed
the
cw/sc-218523/openssl-dynamic-link
branch
from
64c6978 to
0d29f36
Compare
cwaldren-ld
changed the title
cwaldren-ld
changed the title
cwaldren-ld
changed the title
cwaldren-ld
commented
Oct 12, 2023
|
|
||
| option(LD_BUILD_EXAMPLES "Build hello-world examples." ON) | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Throwing a warning when someone tries to build shared lib with unit tests enabled. This won't work since we hide symbols by default.
kinyoklion
reviewed
Oct 12, 2023
| if (NOT LD_BUILD_STATIC_LIBS) | ||
| # When building a shared library we hide all symbols | ||
| # aside from this we have specifically exported for the C-API. | ||
| set(CMAKE_CXX_VISIBILITY_PRESET hidden) |
Member
There was a problem hiding this comment.
Maybe not right now, but we probably need an option for this. For those that build themselves and want to build a C++ dll.
Member
There was a problem hiding this comment.
(If they build all their own stuff, then the ABI issue isn't really an SDK issue.)
kinyoklion
reviewed
Oct 12, 2023
|
|
||
| if (MSVC OR (NOT BUILD_SHARED_LIBS)) | ||
| if (MSVC OR LD_BUILD_STATIC_LIBS) | ||
| target_link_libraries(${LIBNAME} |
Member
There was a problem hiding this comment.
We may want to note this MSVC condition in the readme.
Unless we want to figure out how to make it actually work with dynamically linked boost on windows (world of pain).
kinyoklion
approved these changes
Oct 12, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.1.0</summary> ## [3.1.0](launchdarkly-cpp-client-v3.0.10...launchdarkly-cpp-client-v3.1.0) (2023-10-13) ### Features * clean up LD CMake variables & allow for OpenSSL dynamic link ([#255](#255)) ([ed23c9a](ed23c9a)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.11 to 0.2.0 * launchdarkly-cpp-common bumped from 0.3.7 to 0.4.0 * launchdarkly-cpp-sse-client bumped from 0.1.3 to 0.2.0 </details> <details><summary>launchdarkly-cpp-common: 0.4.0</summary> ## [0.4.0](launchdarkly-cpp-common-v0.3.7...launchdarkly-cpp-common-v0.4.0) (2023-10-13) ### Features * clean up LD CMake variables & allow for OpenSSL dynamic link ([#255](#255)) ([ed23c9a](ed23c9a)) </details> <details><summary>launchdarkly-cpp-internal: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-internal-v0.1.11...launchdarkly-cpp-internal-v0.2.0) (2023-10-13) ### Features * clean up LD CMake variables & allow for OpenSSL dynamic link ([#255](#255)) ([ed23c9a](ed23c9a)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.3.7 to 0.4.0 </details> <details><summary>launchdarkly-cpp-sse-client: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-sse-client-v0.1.3...launchdarkly-cpp-sse-client-v0.2.0) (2023-10-13) ### Features * clean up LD CMake variables & allow for OpenSSL dynamic link ([#255](#255)) ([ed23c9a](ed23c9a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation of the various options used to control the SDK build!
It also cleans up the options by prefixing them with
LD_and making use ofcmake_dependent_optionto expose only relevant options.The default, hands-off configuration is:
Users can then tweak away from the default:
Finally, to simply disable all testing stuff and just produce the SDK, the common
BUILD_TESTINGflag can be disabled. That'll force any of the testing related flags off - use case is build scripts / package maintainers.