feat: implement event delivery #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #194283: Implement Event processor. |
cwaldren-ld
force-pushed
the
cw/sc-194283/event-delivery
branch
from
c99b674 to
72b613c
Compare
cwaldren-ld
changed the title
kinyoklion
reviewed
May 1, 2023
kinyoklion
reviewed
May 1, 2023
kinyoklion
approved these changes
May 1, 2023
There was a problem hiding this comment.
As long as the only bottleneck is IO, this looks good. That is certainly the case for the client.
In the case where there was a CPU bottleneck, then I think we would want the workers to have the ability to be threaded. For instance in a server where serialization in creating the batch could be the bottleneck for single threaded event dispatch
This was referenced May 8, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a state machine based approach for delivering events.
There's a worker pool, and 5 workers (configurable). They are meant to be long-lived and at any given moment are:
I've update
Clientto construct anAsioEventProcessorif events are enabled, otherwise aNullEventProcessor.