feat: scaffold libs/server-sdk-dynamodb-source#533
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b72555d. Configure here.
kinyoklion
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Scaffolds a new
libs/server-sdk-dynamodb-sourcelibrary that mirrorslibs/server-sdk-redis-source, plus theaws-sdk-cppdependency wiring.No functional code. Proves that the AWS C++ SDK builds cleanly in our CMake/CI setup.
What's in the box
cmake/aws-sdk-cpp.cmake— FetchContent foraws-sdk-cpp@1.11.805withBUILD_ONLY=dynamodb,ENABLE_TESTING=OFF, andGIT_SUBMODULES_RECURSE TRUE(the SDK still uses submodules foraws-crt-cppand the underlying AWS C runtime libs). Build pruned toaws-cpp-sdk-dynamodb+aws-cpp-sdk-core+ the CRT stack — no other AWS service clients compile.libs/server-sdk-dynamodb-source/— CMake / package / Doxygen / README skeleton parallelingserver-sdk-redis-source. The lonedynamodb_source.cppreferencesAws::DynamoDB::DynamoDBClientinside a never-called function so the link againstaws-cpp-sdk-dynamodbis exercised by this PR rather than deferred.LD_BUILD_DYNAMODB_SUPPORTCMake option (default OFF) wired into the top-levelCMakeLists.txt.scripts/build.sh— special-cases the new target to flipLD_BUILD_DYNAMODB_SUPPORT=ON, matching the existing redis/otel pattern that the.github/actions/cicomposite already uses..github/workflows/server-dynamodb.yml— build-only CI matrix onubuntu-22.04/macos-15/windows-2022, so "AWS SDK builds cleanly in CI" is actually verified by this PR.release-please-config.json+.release-please-manifest.json— new package registered at0.1.0withbump-minor-pre-major: true(matchingserver-sdk-otel, the only other pre-stable package)..github/workflows/manual-sdk-release-artifacts.yml— new package added to the manual releaseoptions.Out of scope (deferred to later PRs)
DynamoDBDataSourceimplementationIBigSegmentStoreinterface + DynamoDB/Redis big-segment implementations.github/workflows/release-please.yml— deferred until the package has functional artifacts to release.Test plan
cmake -G Ninja -B build -DLD_BUILD_DYNAMODB_SUPPORT=ON .thencmake --build build --target launchdarkly-cpp-server-dynamodb-sourceproducesliblaunchdarkly-cpp-server-dynamodb-source.a.cmake -G Ninja -B build .produces nodynamodboraws-sdktargets inninja -t targets all.Risks / things reviewers should look at
aws-sdk-cpptag pin (1.11.805) is recent.scripts/build.shnow has three "special-case" branches (redis, otel, dynamodb).Note
Medium Risk
Introduces a new optional build path that fetches and links the AWS C++ SDK via CMake/FetchContent, which can impact build times and CI stability across platforms. Functional behavior is minimal, but release/CI plumbing changes could affect packaging if misconfigured.
Overview
Adds a new scaffold library,
libs/server-sdk-dynamodb-source, with a placeholder API and CMake target (launchdarkly::server_dynamodb_source) that links againstaws-sdk-cpp(DynamoDB-only) to validate dependency wiring.Wires this component into the repo’s build and release tooling: new
LD_BUILD_DYNAMODB_SUPPORTtoggle in the top-levelCMakeLists.txt,scripts/build.shspecial-casing to enable it only for the DynamoDB targets, a dedicated CI workflow (server-dynamodb.yml) for Linux/macOS/Windows build-only checks, and updates torelease-please+ the manual artifact release workflow to recognize the new package at version0.1.0.Reviewed by Cursor Bugbot for commit b72555d. Bugbot is set up for automated code reviews on this repo. Configure here.