feat: add ApplicationTags #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #194969: Implement Application Tags. |
Base automatically changed from
cw/sc-194957/common-config
to
cw/sc-194812/service-endpoints-config
March 30, 2023 16:32
cwaldren-ld
force-pushed
the
cw/sc-194969/application-tags
branch
4 times, most recently
from
122a023 to
6fa4594
Compare
cwaldren-ld
force-pushed
the
cw/sc-194969/application-tags
branch
3 times, most recently
from
4b6f45f to
75e6343
Compare
cwaldren-ld
commented
Mar 31, 2023
cwaldren-ld
commented
Mar 31, 2023
| tags_.emplace_back(std::move(key), std::move(value)); | ||
| } | ||
| // todo: error handling if not valid | ||
| return *this; |
There was a problem hiding this comment.
Will update once the tl::expected PR goes through.
kinyoklion
reviewed
Mar 31, 2023
kinyoklion
approved these changes
Apr 3, 2023
cwaldren-ld
force-pushed
the
cw/sc-194969/application-tags
branch
from
29afb61 to
4385344
Compare
kinyoklion
approved these changes
Apr 3, 2023
This was referenced May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ApplicationInfobuilder and tests. I copied the naming from Rust - rather than calling it anApplicationInfoBuilderor whatever.TBD if this is a good idea, I think I'll do a renaming pass next week.
In order to report errors, I've introduced a shared
error.hppheader containing error codes. We can then ensure no overlapping codes, and have a central place to define error strings.