feat: Add support for logging configuration. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
May 15, 2023
| std::chrono::seconds{30})) | ||
| .WithReasons(true) | ||
| .UseReport(true)) | ||
| .Logging(LoggingBuilder::BasicLogging().Level(LogLevel::kDebug)) |
Member
Author
There was a problem hiding this comment.
There are some implicit constructors to make setting the logging method simpler. Here there is a basic logging builder getting converted into a LoggingBuilder.
kinyoklion
commented
May 15, 2023
| #include <launchdarkly/config/client.hpp> | ||
| #include <launchdarkly/config/server.hpp> | ||
| #include "null_logger.hpp" | ||
| #include <launchdarkly/logging/null_logger.hpp> |
Member
Author
There was a problem hiding this comment.
Null logger is now used to disable logging. So it was moved to internal.
kinyoklion
commented
May 15, 2023
| private: | ||
| LogLevel level_; | ||
| std::string name_; | ||
| std::mutex write_mutex_; |
Member
Author
There was a problem hiding this comment.
Just to allow log entries not to overlap. If you want a high performance lock-free logger, then replace our logger.
kinyoklion
commented
May 16, 2023
| * @return Returns true if the level is enabled. | ||
| */ | ||
| virtual bool Enabled(LogLevel level) = 0; | ||
| virtual bool Enabled(LogLevel level) noexcept = 0; |
Member
Author
There was a problem hiding this comment.
Seemed like a good idea to make these noexcept.
cwaldren-ld
reviewed
May 16, 2023
cwaldren-ld
approved these changes
May 16, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for configuring logging.
Did not add c-bindings yet.