feat: implement remaining config C bindings #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #201468: Create C bindings for Config type. |
cwaldren-ld
force-pushed
the
cw/sc-201468/config-bindings
branch
from
d8a75eb to
2851d49
Compare
cwaldren-ld
commented
May 17, 2023
| .WithReasons(true) | ||
| .UseReport(true); | ||
| config_builder.Logging().Logging( | ||
| LoggingBuilder::BasicLogging().Level(LogLevel::kDebug)); |
Contributor
Author
There was a problem hiding this comment.
Could probably slightly improve this by adding Basic()/Custom() members to the logging builder, so it's not Logging().Logging. Hmm
cwaldren-ld
commented
May 17, 2023
| #include <launchdarkly/bindings/c/status.h> | ||
|
|
||
| #include <stdio.h> | ||
|
|
cwaldren-ld
commented
May 17, 2023
| * severity. | ||
| * severity. The values must not be changed to ensure backwards compatibility | ||
| * with the C API. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
We could use a switch instead of static_cast. It's just annoying.
kinyoklion
reviewed
May 18, 2023
kinyoklion
reviewed
May 18, 2023
| std::map<std::string, std::string>{{"color", "green"}})); | ||
| builder.HttpProperties() | ||
| .ConnectTimeout(std::chrono::milliseconds{1234}) | ||
| .ReadTimeout(std::chrono::milliseconds{123456}) |
kinyoklion
approved these changes
May 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing of note is probably the custom logging backend. This is a struct with a couple of function pointers + user data void pointer.
I've provided a wrapper that converts that into an
ILogBackend.Aside from that, everything else is mostly straightforward.