feat: expose prerequisite relations in AllFlags API #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Oct 30, 2024
cwaldren-ld
changed the title
kinyoklion
approved these changes
Nov 8, 2024
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Nov 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.8.1</summary> ## [3.8.1](launchdarkly-cpp-client-v3.8.0...launchdarkly-cpp-client-v3.8.1) (2024-11-08) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.9.0 to 0.10.0 </details> <details><summary>launchdarkly-cpp-internal: 0.10.0</summary> ## [0.10.0](launchdarkly-cpp-internal-v0.9.0...launchdarkly-cpp-internal-v0.10.0) (2024-11-08) ### Features * expose prerequisite relations in AllFlags API ([#463](#463)) ([56de5f5](56de5f5)) </details> <details><summary>launchdarkly-cpp-server: 3.8.0</summary> ## [3.8.0](launchdarkly-cpp-server-v3.7.0...launchdarkly-cpp-server-v3.8.0) (2024-11-08) ### Features * expose prerequisite relations in AllFlags API ([#463](#463)) ([56de5f5](56de5f5)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.9.0 to 0.10.0 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.16</summary> ## [2.1.16](launchdarkly-cpp-server-redis-source-v2.1.15...launchdarkly-cpp-server-redis-source-v2.1.16) (2024-11-08) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.7.0 to 3.8.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
AllFlags()API to gather and expose prerequisite information for flags.The prereqs are available via
State::Prerequisites(), and are more importantly serialized in the JSON representation of the bootstrap payload.The implementation strategy was to create a custom
IEventProcessorspecifically forAllFlagsusage. Previously,AllFlagsinvoked the evaluator with a no-opEventScope, which made event creation a no-op within the eval algorithm.This change now passes in a
PrereqEventRecorderwhich tracks the top-level prerequisites of each flag.