-
Notifications
You must be signed in to change notification settings - Fork 8
chore: adds FDv1 Fallback support to FDv2 Data Source #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctional-data-source-updates
…rlamb/sdk-1584/fdv2-polling-data-source
…rlamb/sdk-1584/fdv2-polling-data-source
…rlamb/sdk-1584/fdv2-polling-data-source
…-1589/data-system-configurtion
…-1589/data-system-configurtion
…-1589/data-system-configurtion
Co-authored-by: Todd Anderson <127344469+tanderson-ld@users.noreply.github.com>
…2-data-system' into ta/SDK-1591/fdv1-fallback
Contributor
Author
|
Need to update references pointing to EventSource of Internal before this merges. |
pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2PollingDataSource.cs
Outdated
Show resolved
Hide resolved
kinyoklion
approved these changes
Dec 16, 2025
Member
kinyoklion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The couple comments that cursor bot made seem accurate, but if those are addressed, then it looks good.
Member
|
Can we pass any more contract tests now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Will be done as final integration testing
Note
Adds FDv1 fallback to FDv2 data sources, triggered by the
x-ld-fd-fallbackheader and configured via SDK DataSystem to use a polling fallback synchronizer.FDv1FallbackActionApplierinFDv2DataSourceto switch from FDv2 synchronizers to FDv1 synchronizers whenErrorInfo.FDv1Fallbackis true.CompositeSource.DataSourceStatus.ErrorInfo.FDv1Fallbackflag.FDv2PollingDataSourceandFDv2StreamingDataSourcewhen thex-ld-fd-fallbackheader is present on HTTP errors.SdkClientEntity, configure FDv1 polling fallback synchronizer derived from the selected synchronizer and align global pollingServiceEndpointswhen a custom polling base URI is provided.test-supressions-fdv2.txtto reflect new FDv1 fallback handling.LaunchDarkly.EventSourceto5.3.0andLaunchDarkly.InternalSdkto3.6.0.Written by Cursor Bugbot for commit 25910ad. This will update automatically on new commits. Configure here.